1858782 - browser.tabs.warnOnClose makes quiting from GNOME's menu bar a huge pain

Status: NEW

(Firefox :: Tabbed Browser, defect)

Description

[Jonathan Watt [:jwatt]]

It seems like browser.tabs.warnOnClose has changed behavior to now require the user to make a confirmation for every...single...window when quiting. I'm not seeing a bug to make this change - was it intentional?

For anyone like me who has a dozen windows open for different topics this change is painful, especially since I have Firefox is set to restore all my windows and tabs on restart, so quiting is not when I want this prompt.

Can we restore the previous behavior? I personally only want browser.tabs.warnOnClose to prevent me from accidentally closing a window (sometimes without noticing because I fat-fingered a shortcut) and losing a window-full of tabs.

Comment 1

[Jonathan Watt [:jwatt]]

FWIW I've tried adding browser.warnOnQuit=false to see if that would override browser.tabs.warnOnClose specifically for the quit case, but that doesn't help.

Comment 2

[Jonathan Watt [:jwatt]]

This seems to only happen on Linux when closing Firefox using "Quit" from the app menu bar at the top-left of the screen (GNOME). It does not happen when using "Quit" from Firefox's hamburger menu or using Ctrl-Q. Maybe this has always been the behavior of using the GNOME menu and is an unpleasant side effect of the way GNOME triggers an app to close? (Closes each window individually, or something?)

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:dao, could you have a look please?

For more information, please visit BugBot documentation.

Comment 4

[Dão Gottwald [:dao]]

(In reply to Jonathan Watt [:jwatt] from comment #2)

This seems to only happen on Linux when closing Firefox using "Quit" from the app menu bar at the top-left of the screen (GNOME). It does not happen when using "Quit" from Firefox's hamburger menu or using Ctrl-Q. Maybe this has always been the behavior of using the GNOME menu and is an unpleasant side effect of the way GNOME triggers an app to close? (Closes each window individually, or something?)

Yeah, we have a similar issue on Windows in bug 1818971. I don't know why both Windows and GNOME behave that way, but perhaps we could better detect this case of all windows closing simultaneously and treat that as quit? Gonna move this back to General, but perhaps this should live in Core::Widget or so.

Comment 5

[Dão Gottwald [:dao]]

:karlt, :stransky, is there something that could be done here on the widget side? Does GNOME send any command here that is different from what we'd see when single windows closing?

Apparently Chrome doesn't suffer from this because it doesn't have a confirmation dialog when closing a window with multiple tabs.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Sure, will look at it. Anyway, would be helpful to get regression window. Jonathan, can you use mozregression tool to find which commit broke it?
https://fedoraproject.org/wiki/How_to_debug_Firefox_problems#Use_Mozregression_tool
Thanks.

Comment 7

[Daniel Bodea [:danibodea]]

:jwatt, since the "regressionwindow-wanted" tag is applied to your report, I would like to attempt a regression investigation for your problem. I am having a bit of trouble in determining the clear steps to reproduce. To properly investigate your issue, i need to clearly understand your problem.

From what I understand, the steps to reproduce would sound like this:

1. Have one or more windows with several tabs loaded (not private windows)
2. Have pref browser.tabs.warnOnClose set to TRUE.
3. Have session restore enabled ("Open previous windows and tabs" checkbox checked in about:preferences)
4. Right-click on the Firefox icon from the Linux taskbar and select "Quit" or "Quit <<number>> windows"
   Expected: The "close confirmation" modal is displayed for each window.
   Actual: The "close confirmation" modal is not displayed.

Please clearly answer these questions on by one:
A. Are the steps above the same as your steps? If not, can you clear them up?
B. From the title, does "quiting from GNOME's menu bar" refer to closing from the context menu of the icon on the taskbar of Linux? (right-clicking the browser icon on the Gnome taskbar and selecting the "Quit" option?)
C. Please tell us the values of the following preferences from about:config page:
a. browser.tabs.warnOnClose = true or false?
b. browser.tabs.warnOnCloseOtherTabs = true or false?
c. browser.tabs.closeWindowWithLastTab= true or false?
D. Could you have been using Private Browsing when the issue reproduced?
E. Can you still reproduce your issue in the latest version of Firefox?

Thank you for your help!