1858827 - [wpt-sync] Sync PR 42177 - [scoped-registry] Properly upgrade elements on adding definition

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 42177 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/42177
Details from upstream follow.

Xiaocheng Hu <[e-mail]> wrote:

[scoped-registry] Properly upgrade elements on adding definition

This patch implements custom element upgrade after adding a
definition to scoped registries, such that:

• Only connected elements with a frame are upgraded
• Only elements in relevant tree scopes are upgraded
• When candidates are in multiple documents, they are upgraded in
  document association order

The sorting utilizes existing CustomElementUpgradeSorter, which was
implemented for one document only, but the same implementation actually
supports sorting elements in multiple documents one-by-one without
any change. So this patch simply uses it.

Bug: 1304439
Change-Id: I6994679d7967a4d169c3fdfa8cd29b69615f83e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4888750
Reviewed-by: Joey Arhar \<[e-mail]>
Commit-Queue: Xiaocheng Hu \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1209169}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=596c7f42e7cbdfa596a394c553a8b972858a2e0e

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 7 subtests

Status Summary

Firefox

OK : 2
PASS: 2
FAIL: 18

Chrome

OK : 2
PASS: 12
FAIL: 8

Safari

OK : 2
PASS: 2
FAIL: 18

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /custom-elements/scoped-registry/scoped-registry-define-upgrade-criteria.tentative.html [wpt.fyi]
  • Adding definition to global registry should not affect shadow roots using scoped registry: FAIL (Chrome: PASS, Safari: FAIL)
  • Adding definition to scoped registry should affect all associated shadow roots: FAIL (Chrome: PASS, Safari: FAIL)
  • Adding definition to scoped registry should not affect document tree scope: FAIL (Chrome: PASS, Safari: FAIL)
  • Adding definition to scoped registry should not affect shadow roots using other registries: FAIL (Chrome: PASS, Safari: FAIL)
  • Adding definition to global registry should not upgrade nodes no longer using the registry: FAIL (Chrome: FAIL, Safari: FAIL)
  • Adding definition to scoped registry should not upgrade nodes no longer using the registry: FAIL (Chrome: FAIL, Safari: FAIL)
  • Adding definition to scoped registry affects associated shadow roots in all iframes: FAIL (Chrome: FAIL, Safari: FAIL)
  • Adding definition to scoped registry affects associated shadow roots in other frame trees: FAIL (Chrome: FAIL, Safari: FAIL)
  • Adding definition to scoped registry should not upgrade disconnected elements: FAIL (Chrome: PASS, Safari: FAIL)
  • Adding definition to scoped registry should not upgrade nodes in constructed documents: FAIL (Chrome: PASS, Safari: FAIL)
  • Adding definition to scoped registry should not upgrade nodes in detached frames: FAIL (Chrome: PASS, Safari: FAIL)
• /custom-elements/scoped-registry/scoped-registry-define-upgrade-order.tentative.html [wpt.fyi]
  • Upgrade in tree order in the same tree scope: FAIL (Chrome: PASS, Safari: FAIL)
  • Upgrade in shadow-including tree order across tree scopes: FAIL (Chrome: PASS, Safari: FAIL)
  • Upgrade order does not depend on shadow root attach order: FAIL (Chrome: PASS, Safari: FAIL)
  • Upgrade in association order across documents, then tree order in each document: FAIL (Chrome: FAIL, Safari: FAIL)
  • Upgrade order is not affected by DOM order between child frames: FAIL (Chrome: FAIL, Safari: FAIL)
  • Upgrade order is affected by shadow tree adoption across documents: FAIL (Chrome: FAIL, Safari: FAIL)
  • Elements in the "owner" window of a scoped registry are not always upgraded first: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a21f6f1d5ec6
[wpt PR 42177] - [scoped-registry] Properly upgrade elements on adding definition, a=testonly
https://hg.mozilla.org/integration/autoland/rev/42337e6777bf
[wpt PR 42177] - Update wpt metadata, a=testonly

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a21f6f1d5ec6
https://hg.mozilla.org/mozilla-central/rev/42337e6777bf