1858994 - Punycode is shown in history

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[faveoled]

Attachment: punycode.gif

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/118.0

Steps to reproduce:

Visit https://рнидс.срб
Click on address bar emptiness, then click again

Actual results:

Cyrillic symbols are replaced to punycode in history

Expected results:

Cyrillic symbols are shown as they are

Comment 1

[Stephanie Cunnane [:scunnane]]

We were able to reproduce this and it's still valid for the heuristic visit result.

Comment 2

[Marc Seibert (:mseibert)]

Attachment: Bug 1858994 - Punycode is shown in heuristic result.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e65fca949600
Punycode is shown in heuristic result.r=mak

Comment 4

[Serban Stanca [:SerbanS]]

Backed out for causing multiple failures.

• Backout link

• Push with failures - xpchell failures

• Failure Log

• Failure line: TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/unit/test_autofill_bookmarked.js | xpcshell return code: 0

---

• Push with failures - mochitests failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_autoFill_trimURLs.js | Autocomplete result should have displayed title as expected for search 'sec' - "https://www.secureautofillurl.com/" == "https://www.secureautofillurl.com" - {"filename":"chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_autoFill_trimURLs.js","name":"promiseTestResult","sourceId":1232,"lineNumber":54,"columnNumber":10,"

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:mseibert, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ea989327044
Punycode is shown in heuristic result. r=mak

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/2ea989327044

Comment 8

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on Firefox 118.0 on Ubuntu 22.
Verified as fixed on Firefox Nightly 123.0a1 on Ubuntu 22, macOS 12, Windows 10.

Comment 9

[faveoled]

Attachment: Firefox123.0b2 Punycode

Comment 10

[faveoled]

Ubuntu 22.04.3, Firefox 123.0b2.
Punycode can still be seen on History -> Manage History view (attached screenshot above)

Comment 11

[Marco Bonardo [:mak]]

I think there has been a miscomprehension, as the bug was in the Address Bar Component and thus it has been fixed in the Address Bar, not in the History views.

Sorry about that, I just filed https://bugzilla.mozilla.org/show_bug.cgi?id=1876738 to track the History views.

Comment 12

[faveoled]

Attachment: NotFixed

Comment 13

[faveoled]

Address Bar still shows Punycode sometimes, e.g. when entering this url: https://.срб

Comment 14

[Marco Bonardo [:mak]]

That's either expected because it contains some invalid char, or it's an invalid URI, or it's a bug in the URL parser, as new URL("https://.срб").URI.displaySpec shows Punycode. If that URI is actually valid please file a separate bug in Network.