1859010 - Run Portable Baseline builds in SpiderMonkey CI

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[Chris Fallin [:cfallin]]

The Portable Baseline Interpreter was upstreamed in bug 1855321, but it currently is not tested in any CI configuration.

We should probably add the following two builds:

• Check that PBL builds in a WASI configuration (PBL's original use-case, and an important one to keep compiling); don't run tests, as other WASI builds don't, either.
• Build and run jit-tests/js-tests/etc with a native PBL build. This one I am less sure about; I'd be interested to hear what the SpiderMonkey maintainers think re: tier expectations, etc. If not running tests, I would maybe still hope for a native build to ensure it compiles, but that's not as important as the WASI build above, either.

Comment 1

[Chris Fallin [:cfallin]]

Attachment: Bug 1859010: run native PBL and PBL-wasi builds in SpiderMonkey CI. r=jandem

This patch adds portable baseline builds for SpiderMonkey on both the
native Linux/x86-64 test platform and on wasm32-wasi, and runs tests
on the former.

Comment 2

[Chris Fallin [:cfallin]]

Attachment: Bug 1859010: miscellaneous fixes to PBL in CI. r=iain

This patch fixes a few issues that the CI configuration catches that my
local builds didn't. Fixes include:

• explicit on single-arg constructors
• avoiding an invalid use of a FakeRooted
• passing a const Value& rather than Value-by-value
• ifdef'ing out two "unimplemented CacheIR op" dispatch labels because
  those ops are only conditionally defined under JS_PUNBOX64
• add a PBL temporary disable to a jsapi test that already temporarily
  disables the baseline interpreter and baseline compiler

Depends on D190973

Comment 3

[Chris Fallin [:cfallin]]

Fixed issues uncovered in CI above; here's a clean try run (with pbl, pbl-wasi, and plain linux64 release/debug runs).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3eb8a734e261
run native PBL and PBL-wasi builds in SpiderMonkey CI. r=sfink,jmaher
https://hg.mozilla.org/integration/autoland/rev/580cf9d272f9
miscellaneous fixes to PBL in CI. r=iain

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3eb8a734e261
https://hg.mozilla.org/mozilla-central/rev/580cf9d272f9

Comment 6

[Chris Fallin [:cfallin]]

Re-opening as the pbl taskcluster job was mistakenly added as tier 1 rather than tier 2.

Comment 7

[Chris Fallin [:cfallin]]

Attachment: Bug 1859010: make SM(pbl) CI job tier 2, as intended. r=jandem

Portable Baseline (PBL) is a tier-2 SpiderMonkey feature. The patch to
add PBL builds and tests to CI inadvertently missed a tier: 2 option
on one of the jobs; this patch fixes that.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2e84c88d392
make SM(pbl) CI job tier 2, as intended. r=jandem

Comment 9

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/b2e84c88d392