1859207 - Assert FunctionFlags integrity between FunctionKind and other bits

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

In order to handle native getter/setter with lazy function name, we need to add some flag, or modify existing flag to FunctionFlags.
FunctionFlags and its FunctionKind are used both from native function and interpreted function, and it's better clarifying which bit or kind is used by which one.

for example, FunctionKind::Getter seems to be used only from interpreted function, and
native getter/setter defined with JSPropertySpec uses FunctionKind::NormalFunction, which is confusing, and it at least requires comment and possibly assertions.

This will clarify which bits are used by which case, and also allows compressing flag bits, by sharing single bit from different kind for different purpose.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1859207 - Assert FunctionFlags integrity between FunctionKind and other bits. r?jandem!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4091bed4a0aa
Assert FunctionFlags integrity between FunctionKind and other bits. r=jandem

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/4091bed4a0aa