1859211 - Align ARIA reflection WebIDL with the structure defined in the spec

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[James Teh [:Jamie]]

Spun off https://phabricator.services.mozilla.com/D190751#inline-1058647.

Currently, we have AriaAttributes.webidl and AccessibilityRole.webidl in dom/webidl. The spec combines these into ARIAMixin.webidl. We should merge our webidl files so that they are aligned with the spec.

The spec's WebIDL includes element reflection, which we don't support yet. From Edgar:

it is fine that an interface implement only part of attributes/methods. Generally, we still list the unimplemented attributes/methods but comment them out, e.g. https://searchfox.org/mozilla-central/rev/6e5b9a5a1edab13a1b2e2e90944b6e06b4d8149c/dom/webidl/CSSFontFeatureValuesRule.webidl#18. :)

Comment 1

[Thomas Wisniewski [:twisniewski]]

This will help us pass the interop2024 WPT https://wpt.fyi/results/wai-aria/idlharness.window.html

Comment 2

[James Teh [:Jamie]]

:twisniewski, why do you think this will help us pass that test? This bug is just about merging the two webidl files we have into a single webidl so that it's closer to the spec. However, it's purely cosmetic; it's not about implementing anything we don't already implement.

Note that the *Element* methods are part of ARIA element reflection, which should have been excluded from Interop 2024. ariaBrailleLabel/Description is covered by bug 1861201.

Comment 3

[Thomas Wisniewski [:twisniewski]]

:Jamie, ah, that was just my naivete showing. We'll want want to confirm why the tests ended up on interop2024 in that case.

Comment 4

[James Teh [:Jamie]]

Yup, I'm asking about that. I'll update here when I learn more.

Comment 5

[James Teh [:Jamie]]

It isn't excluded. We plan to work on element reflection in h2. But this bug is still mostly just cosmetic. The real element reflection work is tracked in bug 1878816.

Comment 6

[James Teh [:Jamie]]

Attachment: Bug 1859211: Merge AccessibilityRole and AriaAttributes interfaces into ARIAMixin.webidl to align with the spec.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fcdb3e9046c6
Merge AccessibilityRole and AriaAttributes interfaces into ARIAMixin.webidl to align with the spec. r=nlapre,webidl,edgar

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/fcdb3e9046c6