185926 - asserting when forwarding signed mail

Status: RESOLVED WORKSFORME

(MailNews Core :: Security: S/MIME, defect)

Description

[(not reading, please use [e-mail] instead)]

ERT() [so we abort in debug builds] when forwarding certain mail

here's my stack:

NTDLL! 77f97704()
MimeMultipartSigned_emit_child(MimeObject * 0x050a26d8) line 603 + 39 bytes
MimeMultipartSigned_parse_eof(MimeObject * 0x050a26d8, int 0) line 161 + 9 bytes
MimeContainer_parse_eof(MimeObject * 0x050a8a20, int 0) line 141 + 16 bytes
MimeMessage_parse_eof(MimeObject * 0x050a8a20, int 0) line 545 + 14 bytes
mime_display_stream_complete(_nsMIMESession * 0x050a8b00) line 918 + 16 bytes
nsStreamConverter::OnStopRequest(nsStreamConverter * const 0x05098b78,
nsIRequest * 0x0509f814, nsISupports * 0x050a8bd8, unsigned int 0) line 1071 +
13 bytes
nsMsgProtocol::OnStopRequest(nsMsgProtocol * const 0x0509f810, nsIRequest *
0x050a0024, nsISupports * 0x050a8bd8, unsigned int 0) line 341 + 88 bytes
nsMailboxProtocol::OnStopRequest(nsMailboxProtocol * const 0x0509f810,
nsIRequest * 0x050a0024, nsISupports * 0x050a8bd8, unsigned int 0) line 374
nsOnStopRequestEvent::HandleEvent() line 213
nsARequestObserverEvent::HandlePLEvent(PLEvent * 0x050a2574) line 116
PL_HandleEvent(PLEvent * 0x050a2574) line 644 + 10 bytes
PL_ProcessPendingEvents(PLEventQueue * 0x010079e8) line 574 + 9 bytes
_md_EventReceiverProc(HWND__ * 0x00040132, unsigned int 49529, unsigned int 0,
long 16808424) line 1335 + 9 bytes
USER32! 77e3a290()
USER32! 77e145b1()
USER32! 77e1a752()
nsAppShellService::Run(nsAppShellService * const 0x01092bd8) line 472
main1(int 2, char * * 0x00284f90, nsISupports * 0x00276eb8) line 1543 + 32 bytes
main(int 2, char * * 0x00284f90) line 1904 + 37 bytes
mainCRTStartup() line 338 + 17 bytes
KERNEL32! 77e9ca90()

looking into it.  for starters, I'll change the PR_ASSERT() to NS_ASSERTION(),
so we don't call abort.

Comment 1

[(not reading, please use [e-mail] instead)]

it's when I forward a signed mail (from jgaunt) as attachment.

I've got a patch that turn the abort() into an assertion, which is worth
checking in.

then I'll morph the bug to be about the assertion.

Comment 2

[(not reading, please use [e-mail] instead)]

Attachment: patch, turns PR_ASSERT() [abort()] into NS_ASSERTION()

Comment 3

[(not reading, please use [e-mail] instead)]

morphing bug to be about asserting, since I've checked in the change.

kaie, if you want to take this from me, feel free.

Comment 4

[Kai Engert [:KaiE:]]

I have never seen this problem before, and I am unable to reproduce with a 1.2.1
build (not having your patch).

Taking bug. I would like to see the problem myself. Seth, could you help me
reproduce it? Did it happen with any signed message from jgaunt?

Comment 5

[Kai Engert [:KaiE:]]

John, could you please send me a signed message and cc Seth?

Comment 6

[Charles Rosendahl]

Unable to reproduce it using the latest daily non-debug builds.

Comment 7

[Kai Engert [:KaiE:]]

I never run into the assertion, whatever I try.
Suggesting worksforme.

Comment 8

[Kai Engert [:KaiE:]]

Resolving to worksforme as suggested.