1859294 - browser_theme_switching.js fails when run by itself

Status: RESOLVED FIXED

(DevTools :: General, defect, P2)

Description

[Dave Townsend [:mossop]]

Running browser_theme_switching.js by itself gives the following errors:

  FAIL :root has theme-auto class (current theme) -
Stack trace:
chrome://mochikit/content/browser-test.js:test_ok:1583
chrome://mochitests/content/browser/devtools/client/shared/test/browser_theme_switching.js:null:26
chrome://mochikit/content/browser-test.js:handleTask:1134
chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1206
chrome://mochikit/content/browser-test.js:Tester_execTest:1348
chrome://mochikit/content/browser-test.js:nextTest/<:1123
chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
  FAIL Uncaught exception in test bound  - at chrome://mochitests/content/browser/devtools/client/shared/test/browser_theme_switching.js:49 - TypeError: can't access property "stylesheets", gDevTools.getThemeDefinition(...) is null
Stack trace:
@chrome://mochitests/content/browser/devtools/client/shared/test/browser_theme_switching.js:49:37
async*handleTask@chrome://mochikit/content/browser-test.js:1134:26
_runTaskBasedTest@chrome://mochikit/content/browser-test.js:1206:18
Tester_execTest@chrome://mochikit/content/browser-test.js:1348:14
nextTest/<@chrome://mochikit/content/browser-test.js:1123:14
SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13

Running browser_theme.js beforehand makes the test pass.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1859294 - [devtools] Force light theme in browser_theme_switching.js

Comment 3

[Intermittent Failures Robot]

11 failures in 3484 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 9
• mozilla-central: 2

Platform and build breakdown:

• linux1804-64-qr: 2
  • debug: 1
  • opt: 1
• windows11-32-2009-qr: 2
  • debug: 1
  • opt: 1
• linux1804-64-tsan-qr: 1
  • opt: 1
• macosx1015-64-qr: 2
  • debug: 1
  • opt: 1
• windows11-64-2009-qr: 2
  • opt: 1
  • debug: 1
• windows11-64-2009-ccov-qr: 1
  • opt: 1
• linux1804-64-ccov-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1859294&startday=2023-10-16&endday=2023-10-22&tree=all

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a8d11fcc746
[devtools] Force light theme in browser_theme_switching.js r=devtools-reviewers,nchevobbe

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2a8d11fcc746