1859355 - EditorEventListener::HandleEvent should stop handling event when certain conditions are met

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect, P3)

Description

[Sean Feng [:sefeng211]]

Basically we should stop handling this event when

• originalEventTargetNode is null
• internalEvent->mMessage is eFocus
• aEvent->GetCurrentTarget is a RootWindow()

To verify the fix, one can run editor/libeditor/crashtests/1424450.html can confirm the following warnings doesn't appear anymore.

 0:28.64 GECKO(1202335) [Child 1203360, Main Thread] WARNING: '!originalEventTargetNode', file /home/sefeng/.local/workspace/mozilla/mozilla-unified2/editor/libeditor/EditorEventListener.cpp:1152
 0:28.64 GECKO(1202335) [Child 1203360, Main Thread] WARNING: EditorEventListener::Focus() failed: 'NS_SUCCEEDED(rv)', file /home/sefeng/.local/workspace/mozilla/mozilla-unified2/editor/libeditor/EditorEventListener.cpp:473

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1817723

Comment 2

[Sean Feng [:sefeng211]]

This relates to a warning message, updating the flags accordingly.

Comment 3

[Ajay]

Hello, Sean Feng [:sefeng]
I attempted to replicate the warning by executing the command ./mach test editor/libeditor/crashtests/1424450.html but couldn't. Additionally, I adjusted the 'mozconfig' to activate debug mode.

This is the result I got: https://pastebin.mozilla.org/DPmLvzzQ

Comment 4

[Sean Feng [:sefeng211]]

Can I see your mozconfig? This doesn't look like a debug build https://pastebin.mozilla.org/DPmLvzzQ#L73

Comment 5

[Ajay]

mozconfig: https://pastebin.mozilla.org/SysoLDpa

https://firefox-source-docs.mozilla.org/setup/configuring_build_options.html

I created a blank mozconfig file in the source dir (mozilla-unified/mozconfig) and added this line to it ac_add_options --enable-debug

Comment 6

[Sean Feng [:sefeng211]]

That looks correct. You need to build and run with that config file. I can't tell what's wrong. Maybe do something like

env MOZCONFIG=/path/to/that/mozconfig/file ./mach build 

env MOZCONFIG=/path/to/that/mozconfig/file ./mach test  editor/libeditor/crashtests/1424450.html

and see if this fixes it?

Comment 7

[Ajay]

Attachment: Bug 1859355 EditorEventListener::HandleEvent should stop handling event if the originalEventTargetNode is null, internalEvent->mMessage is eFocus or aEvent->GetCurrentTarget is a RootWindow r?sefeng

Depends on D191211

Comment 8

[Ajay]

Thanks. After a clean build, I was able to replicate the warning.

Comment 9

[Ajay]

Attachment: Bug 1859355 - Exit EditorEventListener::HandleEvent early when the event can't be handled

Depends on D191211

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba7e57fccd2a
Exit EditorEventListener::HandleEvent early when the event can't be handled r=sefeng

Comment 11

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/ba7e57fccd2a

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:exactlyajay.chauhan, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox120 to wontfix.

For more information, please visit BugBot documentation.

Comment 13

[Sean Feng [:sefeng211]]

This just fixes some warnings. No need to uplift