1859488 - Inconsistent PB icon on homepage

Status: VERIFIED FIXED

(Firefox for Android :: General, defect)

Description

[Delia Pop (Android QA)]

Attachment: AppVSFigma.png

Preconditions

Enroll in the https://stage.experimenter.nonprod.dataops.mozgcp.net/nimbus/dpop-simplified-nav/summary Experiment using Nimbus-cli.

Steps to reproduce

1. Launch the application and enter the private browsing mode.
2. Observe the Private Browsing icon (used to access the PBM, upper right corner of the screen).

Expected behavior

According to the Figma design, the Private Browsing icon (used to access the PBM, upper right corner of the screen) should be updated.

Actual behavior

The PB icon displayed in app does not match the one in the Figma design.

Device information

• Firefox version: 120.0a1 from 10/17
• Android device model & Android OS version: Samsung Galaxy A53 5G (Android 13)

Comment 1

[Jeff Boek [:boek]]

I believe the Figma may be out of date. We're using the new icon that was given to use by UX here: https://bugzilla.mozilla.org/show_bug.cgi?id=1855737

Comment 2

[Delia Pop (Android QA)]

Attachment: PB_Icon.jpg

Hi, Boek, so if I understand correctly, both PB icons displayed on the PB homepage (the Private Browsing mode icon used to access the PBM, upper right corner of the screen and the PB mask icon displayed on the badge tab icon/tab counter) should use the same icon?
I raised this concern on 1855737 as well, with no reply yet, but I think we'd have to double check this with UX to determine if this bug should be closed as invalid.

Comment 3

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1859488 - Updates mask in private_browsing_button.xml (#4148)

Comment 4

[BMO Github Automation]

Authored by https://github.com/boek
https://github.com/mozilla-mobile/firefox-android/commit/a7d772b71f3423b23c8ce0814da4ce9d87e48505
[main] Bug 1859488 - Updates mask in private_browsing_button.xml

Comment 5

[Nicole Weber [:topotropic]]

Thanks for flagging this! We recently updated the mask icons and you'll find the latest version here https://github.com/FirefoxUX/acorn-icons

I also commented on this issue https://bugzilla.mozilla.org/show_bug.cgi?id=1850641#c2

Please reach out if you need anything else. Thanks!

Comment 6

[Delia Pop (Android QA)]

Attachment: PB_Icon.png

Verified fixed on latest Nightly 120.0a1 from 10/19.
Tested with:

• Samsung Galaxy A53 5G (Android 13)
• Lenovo Yoga Tab 11 (Android 12)
• Huawei MediaPad M2 (Android 5.1.1)

Comment 7

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1859488 - Update the private browsing button to use the correct icon (#4173)

Comment 8

[BMO Github Automation]

Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/5d7e8ab06e1f026c7cafb4b80cf3404423d02265
[main] Bug 1859488 - Update the private browsing button to use the correct icon

Comment 9

[Delia Pop (Android QA)]

Attachment: PB_Icon_3.png

Verified fixed on latest Nightly 120.0a1 from 10/20. The icon matches the latest change of design in Figma.
Tested with Samsung Galaxy A53 5G (Android 13)