Closed Bug 1859538 Opened 8 months ago Closed 8 months ago

Allow chrome stylesheets to be parsed in parallel.

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
120 Branch
Tracking Status
firefox120 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

No description provided.

This changes -moz-bool-pref from @supports to @media, bringing various
improvements:

  • @media (-moz-bool-pref) properly reacts to dynamic changes.
  • We no longer need to parse chrome:// stylesheets in the main thread
    (-moz-bool-pref was the only thing that forced us to do that).

This makes privileged and non-privileged stylesheets more similar.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0f84d30b2de4
Allow chrome stylesheets to be parsed in parallel. r=layout-reviewers,desktop-theme-reviewers,dao,Gijs,tlouw
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/fe39bff2df5e
Fix browser_tab_manager_drag.js.
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch
See Also: → 1860202

There is still the moz_gtk_csd_rounded_bottom_corners atom which seems to be unused now. Are there plans to sync widget.gtk.rounded-bottom-corners.enabled or should it be removed?

Flags: needinfo?(emilio)

Not sure what "sync" means in that context, but it can be removed.

Flags: needinfo?(emilio)

(In reply to Norisz Fay [:noriszfay] from comment #7)

https://hg.mozilla.org/mozilla-central/rev/0f84d30b2de4
https://hg.mozilla.org/mozilla-central/rev/3792590da739
https://hg.mozilla.org/mozilla-central/rev/fe39bff2df5e

== Change summary for alert #40019 (as of Mon, 23 Oct 2023 06:58:10 GMT) ==

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
3% ts_paint windows10-64-shippable-qr e10s fission stylo webrender 440.92 -> 429.08
2% sessionrestore windows10-64-shippable-qr e10s fission stylo webrender 490.08 -> 479.25
2% startup_about_home_paint windows10-64-shippable-qr e10s fission stylo webrender 653.04 -> 639.42
2% sessionrestore_no_auto_restore windows10-64-shippable-qr e10s fission stylo webrender 503.96 -> 493.67

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=40019

Regressions: 1863874
Regressions: 1865771
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: