Fakespot bottom sheet's section should remember their expanded state for the current page
Categories
(Fenix :: Shopping, enhancement, P2)
Tracking
(firefox118 disabled, firefox119 disabled, firefox120 wontfix, firefox121 verified)
People
(Reporter: cpeterson, Assigned: rsainani)
References
Details
(Whiteboard: [fxdroid] [fakespot-android-mvp])
Attachments
(2 files)
Steps to reproduce
- Load a PDP.
- Open the Fakespot bottom sheet.
- Expand the "Show more" highlights, "How we determine review quality", and "Settings" sections.
- Close the bottom sheet.
- Reopen the bottom sheet.
Expected behavior
The "Show more" highlights, "How we determine review quality", and "Settings" sections should remember whether they were expanded or closed on the current page.
Actual behavior
The "Show more" highlights, "How we determine review quality", and "Settings" sections are all closed.
Updated•1 year ago
|
Assignee | ||
Comment 1•11 months ago
|
||
I think the current behavior where the user opens the bottom sheet and the cards are in collapsed state is correct. We shouldn't persist the expanded states of each card, it would lead to not being able to see the product recommendation and would be a higher overhead to persist this information.
Assignee | ||
Updated•11 months ago
|
Reporter | ||
Comment 2•11 months ago
|
||
Verdi says we should remember the bottom sheet sections' expanded state as long the user is on the page. If you load another page in that tab then we can forget. We don’t need to remember across app restarts or if the user opens a second tab for the same product page.
Assignee | ||
Updated•11 months ago
|
Assignee | ||
Updated•11 months ago
|
Comment 3•11 months ago
|
||
Comment 4•11 months ago
|
||
Authored by https://github.com/rahulsainani
https://github.com/mozilla-mobile/firefox-android/commit/c4ede23266b730e7c84c3ef1edfeab932a2ec9b2
[main] Bug 1859671 - Remember review checker card states for the session
Comment 5•11 months ago
|
||
Comment 6•11 months ago
|
||
Verified as fixed on Nightly 121.0a1 from 11/16 with Motorola G9 Plus (Android 11) and Sony Xperia (Android 6.0.1).
Description
•