1859680 - Fail in ContentParent::RecvFindImageText() on unsupported configurations

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrew McCreight [:mccr8]]

It would be good to reject this message immediately in ContentParent::RecvFindImageText() if we're in a configuration that doesn't support it (eg if the pref is false or the platform doesn't support it). The stub implementation of the image text finder looks harmless but better safe than sorry. Though that might require adjusting test_image_recognition_unsupported.html.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1859680 - Reject RecvFindImageText() messages on unsupported platforms.

Also, avoid calling SendFindImageText() on unsupported platforms, so that
test_image_recognition_unsupported.html will pass.

Comment 2

[Andrew McCreight [:mccr8]]

I've only tested this on MacOS, but I messed around with it enough that I think I properly tested what will happen on unsupported systems. test_image_recognition_unsupported.html should still pass. If we do send the message somehow, we'll crash the child process or whatever the IPC fail does.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/203c83fdbd8d
Reject RecvFindImageText() messages on unsupported platforms. r=gregtatum

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/203c83fdbd8d

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/203c83fdbd8d