Closed
Bug 1859832
Opened 1 year ago
Closed 1 year ago
isMagic check in CallArgsFromVp results in inefficient code
Categories
(Core :: JavaScript Engine, task)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
120 Branch
| Tracking | Status | |
|---|---|---|
| firefox120 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
(Whiteboard: [sp3])
Attachments
(1 file)
CallArgsFromVp is used in almost all of our C++ builtins, but the vp[1].isMagic(JS_IS_CONSTRUCTING) check results in some unnecessary branches because of the release assertion in isMagic.
|
||
Updated•1 year ago
|
See Also: → https://mozilla-hub.atlassian.net/browse/SP3-605
|
Assignee | |
Comment 1•1 year ago
|
||
This lets Clang get rid of the is-constructing check entirely if it's unused.
CallArgsFromVp is used in almost all of our C++ builtins, so it's worth optimizing.
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d5afe35758f9
Avoid isMagic release assertion in CallArgsFromVp. r=iain
|
||
Comment 3•1 year ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox120:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•