If you define a bookmark (without the "quotes") where %s is used e.g.: Name="SearchIt" URL="http://google.com/search?query=%s&num=10" Keyword="?" If you type "?" alone nothing happens. If you type "? " (?+space) the link is opened but the string "%s" has been used. Build 1217.
What do you expect to happen?
In both cases open the url with the string "" (empty) for some url it will be a quick way to access them, like for google.
IMHO, "? " should expand to "http://www.google.com/search?q=" in this example. Note the end of the expanded URL.
Ideally, I'd like to be able to load one url for keyword followed by a argument and another for just the keyword. Example: Bookmark Name: "Google" URL: "http //www.google.com/search?q=%s" keyword: "?" When typing in "? query", Chimera will load "http //www.google.com/search?q=query", but typing in "?" will load "http://www.google.com/". I guess you could parse it to retrieve only the domain of the URL or the directory that the script is contained in. The only problem with this is having a search script in a different directory than the index, though I don't know how often that would arise.
This bug appears in Firefox (Mac) as well. If you type 'google' into the address bar, it loads a search for %s in google. To my mind, what should happen is that, since you've only typed in one word, it should do a default "I'm feeling lucky" search for that word, and therefore load Google's front page.
Camino doesn't use an "I'm feeling lucky" search when you just type one word, it just appends "http://www." and ".com" to it (personally, I wish Firefox would do the same as I end up at the wrong url half the time, but I digress). What you're suggesting is not really an optimal solution--it would involve ignoring certain bookmark keywords (those that are expecting a search string but don't receive one) which is potentially confusing to the user. I think the most logical (and probably simple) solution is the one suggested in comment #3.
I would have expected no parameters on a keyworded bookmark to use an empty string for %s as opposed to sending the literal '%s' as a parameter.
Created attachment 184108 [details] [diff] [review] make keywords faster and fix this bug v1.0
Attachment #184108 - Flags: superreview?(pinkerton)
Comment on attachment 184108 [details] [diff] [review] make keywords faster and fix this bug v1.0 sr=pink. looks ok to me.
Attachment #184108 - Flags: superreview?(pinkerton) → superreview+
landed on trunk
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.