1859905 - convert .ini manifests to .toml: batch 19 browser_*.ini r=jmaher

Status: RESOLVED FIXED

(Testing :: General, task)

Description

[Tom Marble]

Convert batch 19 of *.ini files to *.toml (see list below)

Success criteria:

• INI files moved to TOML to preserve history
• References to INI files replaced with TOML equivalents (e.g. in moz.build)

Files:

     1 ./browser/base/content/test/tabcrashed/browser_aboutRestartRequired.ini
     2 ./browser/components/extensions/test/browser/browser_legacy_recent_tabs.ini
     3 ./devtools/client/framework/test/allocations/browser_allocations_browser_console.ini
     4 ./devtools/client/framework/test/allocations/browser_allocations_reload_debugger.ini
     5 ./devtools/client/framework/test/allocations/browser_allocations_reload_inspector.ini
     6 ./devtools/client/framework/test/allocations/browser_allocations_reload_netmonitor.ini
     7 ./devtools/client/framework/test/allocations/browser_allocations_reload_no_devtools.ini
     8 ./devtools/client/framework/test/allocations/browser_allocations_reload_webconsole.ini
     9 ./devtools/client/framework/test/allocations/browser_allocations_target.ini
    10 ./devtools/client/framework/test/allocations/browser_allocations_toolbox.ini
    11 ./devtools/client/framework/test/metrics/browser_metrics.ini
    12 ./devtools/client/framework/test/metrics/browser_metrics_debugger.ini
    13 ./devtools/client/framework/test/metrics/browser_metrics_inspector.ini
    14 ./devtools/client/framework/test/metrics/browser_metrics_netmonitor.ini
    15 ./devtools/client/framework/test/metrics/browser_metrics_webconsole.ini
    16 ./devtools/client/netmonitor/test/browser_http3.ini
    17 ./image/test/browser/browser_sandbox_headless.ini
    18 ./ipc/glue/test/browser/browser_audio_fallback.ini
    19 ./ipc/glue/test/browser/browser_audio_fallback_content.ini
    20 ./ipc/glue/test/browser/browser_audio_locked.ini
    21 ./ipc/glue/test/browser/browser_audio_shutdown.ini
    22 ./ipc/glue/test/browser/browser_child_hang.ini
    23 ./netwerk/test/useragent/browser_nonsnap.ini
    24 ./netwerk/test/useragent/browser_snap.ini
    25 ./remote/cdp/test/browser/browser_cdp_only.ini
    26 ./remote/cdp/test/browser/runtime/browser_with_default_prefs.ini
    27 ./security/sandbox/test/browser_snap.ini
    28 ./security/sandbox/test/browser_xdg.ini
    29 ./toolkit/xre/test/win/mochitest/browser_env_path_long.ini

Comment 1

[Tom Marble]

Attachment: Bug 1859905 - convert .ini manifests to .toml: batch 19 browser_*.ini r=jmaher

Comment 2

[Tom Marble]

The following files have been added to this batch:

     1 ./devtools/client/framework/test/browser-telemetry-startup.ini
     2 ./devtools/client/netmonitor/src/har/test/browser-harautomation.ini
     3 ./testing/mochitest/tests/python/files/browser-args.ini
     4 ./browser/components/extensions/test/browser/browser-private.ini
     5 ./toolkit/components/antitracking/test/browser/browser-blocking.ini
     6 ./toolkit/components/extensions/test/browser/browser-serviceworker.ini

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ca403a2c00e
convert .ini manifests to .toml: batch 19 browser_*.ini r=jmaher,webdriver-reviewers,necko-reviewers,extension-reviewers,devtools-reviewers,anti-tracking-reviewers,valentin,robwu,pbz

Comment 4

[Natalia Csoregi [:nataliaCs]]

Backed out for causing failures on test_mochitest_integration.py

• backout: https://hg.mozilla.org/integration/autoland/rev/de59b9ab6230a9b8af2b9ae0c679315eab336cce
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=afXT35JEQKCegYRXxyAYXw.0&revision=1ca403a2c00e0708ccba0ba3821df03ee89458a9
• failure log: https://treeherder.mozilla.org/logviewer?job_id=433789332&repo=autoland&lineNumber=739

[task 2023-10-25T19:12:43.304Z] ============================= test session starts ==============================
[task 2023-10-25T19:12:43.304Z] platform linux -- Python 3.8.10, pytest-7.0.1, pluggy-1.3.0 -- /builds/worker/.mozbuild/srcdirs/gecko-8a5b87fe5d69/_virtualenvs/python-test/bin/python
[task 2023-10-25T19:12:43.304Z] rootdir: /builds/worker/checkouts/gecko, configfile: config/mozunit/mozunit/pytest.ini
[task 2023-10-25T19:12:43.304Z] collecting ... collected 18 items
[task 2023-10-25T19:12:43.304Z] 
[task 2023-10-25T19:12:43.304Z] testing/mochitest/tests/python/test_mochitest_integration.py::test_output_extra_args[plain-mochitest-args.ini] PASSED
[task 2023-10-25T19:12:43.304Z] testing/mochitest/tests/python/test_mochitest_integration.py::test_output_extra_args[browser-chrome-browser-args.ini] TEST-UNEXPECTED-FAIL
[task 2023-10-25T19:12:43.304Z] testing/mochitest/tests/python/test_mochitest_integration.py::test_output_pass[plain-selftest] PASSED
[task 2023-10-25T19:12:43.304Z] testing/mochitest/tests/python/test_mochitest_integration.py::test_output_pass[plain-] PASSED
[task 2023-10-25T19:12:43.304Z] testing/mochitest/tests/python/test_mochitest_integration.py::test_output_pass[browser-chrome-selftest] PASSED
[task 2023-10-25T19:12:43.304Z] testing/mochitest/tests/python/test_mochitest_integration.py::test_output_pass[browser-chrome-] PASSED
[task 2023-10-25T19:12:43.304Z] testing/mochitest/tests/python/test_mochitest_integration.py::test_output_fail[plain-selftest] PASSED
[task 2023-10-25T19:12:43.304Z] testing/mochitest/tests/python/test_mochitest_integration.py::test_output_fail[plain-] PASSED
[task 2023-10-25T19:12:43.304Z] testing/mochitest/tests/python/test_mochitest_integration.py::test_output_fail[browser-chrome-selftest] PASSED
[task 2023-10-25T19:12:43.304Z] testing/mochitest/tests/python/test_mochitest_integration.py::test_output_fail[browser-chrome-] PASSED
[task 2023-10-25T19:12:43.304Z] testing/mochitest/tests/python/test_mochitest_integration.py::test_output_crash[plain-selftest] PASSED
[task 2023-10-25T19:12:43.304Z] testing/mochitest/tests/python/test_mochitest_integration.py::test_output_crash[plain-] PASSED
[task 2023-10-25T19:12:43.304Z] testing/mochitest/tests/python/test_mochitest_integration.py::test_output_crash[browser-chrome-selftest] PASSED
[task 2023-10-25T19:12:43.304Z] testing/mochitest/tests/python/test_mochitest_integration.py::test_output_crash[browser-chrome-] PASSED
[task 2023-10-25T19:12:43.304Z] testing/mochitest/tests/python/test_mochitest_integration.py::test_output_asan[plain-] SKIPPED
[task 2023-10-25T19:12:43.304Z] testing/mochitest/tests/python/test_mochitest_integration.py::test_output_assertion[plain-] PASSED
[task 2023-10-25T19:12:43.304Z] testing/mochitest/tests/python/test_mochitest_integration.py::test_output_leak[plain-] PASSED
[task 2023-10-25T19:12:43.304Z] testing/mochitest/tests/python/test_mochitest_integration.py::test_output_testfile_in_dupe_manifests[plain] PASSED
[task 2023-10-25T19:12:43.304Z] 
[task 2023-10-25T19:12:43.304Z] =================================== FAILURES ===================================
[task 2023-10-25T19:12:43.304Z] ___________ test_output_extra_args[browser-chrome-browser-args.ini] ____________
[task 2023-10-25T19:12:43.304Z] testing/mochitest/tests/python/test_mochitest_integration.py:60: in test_output_extra_args
[task 2023-10-25T19:12:43.304Z]     "manifestFile": test_manifest([manifest]),
[task 2023-10-25T19:12:43.305Z] testing/mochitest/tests/python/test_mochitest_integration.py:40: in inner
[task 2023-10-25T19:12:43.305Z]     return TestManifest(
[task 2023-10-25T19:12:43.305Z] testing/mozbase/manifestparser/manifestparser/manifestparser.py:881: in __init__
[task 2023-10-25T19:12:43.305Z]     ManifestParser.__init__(self, *args, **kwargs)
[task 2023-10-25T19:12:43.305Z] testing/mozbase/manifestparser/manifestparser/manifestparser.py:96: in __init__
[task 2023-10-25T19:12:43.305Z]     self.read(*manifests)
[task 2023-10-25T19:12:43.305Z] testing/mozbase/manifestparser/manifestparser/manifestparser.py:325: in read
[task 2023-10-25T19:12:43.305Z]     raise IOError("Missing files: %s" % ", ".join(missing))
[task 2023-10-25T19:12:43.305Z] E   OSError: Missing files: /builds/worker/fetches/tests/mochitest/browser/tests/selftests/browser-args.ini

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89011af00419
convert .ini manifests to .toml: batch 19 browser_*.ini r=jmaher,webdriver-reviewers,necko-reviewers,extension-reviewers,devtools-reviewers,anti-tracking-reviewers,valentin,robwu,pbz

Comment 6

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/89011af00419

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 9360071 [details]
Bug 1859905 - convert .ini manifests to .toml: batch 19 browser_*.ini r=jmaher

Beta/Release Uplift Approval Request

• User impact if declined: windows debug devtools CI tests will have a task that continues to perma timeout.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): test only
• String changes made/needed:
• Is Android affected?: No

Comment 8

[Dianna Smith [:diannaS]]

Comment on attachment 9360071 [details]
Bug 1859905 - convert .ini manifests to .toml: batch 19 browser_*.ini r=jmaher

Approved for 120.0b8

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/16530aa22902