1859913 - Revert shopping CFR behavior

Status: VERIFIED FIXED

(Fenix :: Shopping, defect, P1)

Description

[Verdi [:verdi] Best to slack me]

We recently made a change to the shopping CFRs that made them harder to dismiss. They can only be dismissed by clicking the close X or by clicking the link that opens the bottom sheet. The issue is that this results in the page and the UI being unresponsive. So we want to revert back to the original behavior where they were dismissible by clicking outside.

I will file an additional bug with a request for new behavior.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1859913 - Revert shopping CFR behavior (#4240)

Comment 2

[BMO Github Automation]

Authored by https://github.com/DreVla
https://github.com/mozilla-mobile/firefox-android/commit/511b2824339d4297c493bfc80d8b383ffe9d4f15
[main] Bug 1859913 - Revert shopping CFR behavior

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:vdreghici, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox120 to wontfix.

For more information, please visit BugBot documentation.

Comment 4

[Adina Petridean QA [:apetridean]]

Verified as fixed on Nightly 121.0a1 from 10/31 with Motorola G9 Plus (Android 11) and Sony Xperia (Android 6.0.1). When taping outside the CFR is dismissed.

Comment 5

[Adina Petridean QA [:apetridean]]

Attachment: CFR.mp4

Comment 6

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1859913 - Revert shopping CFR behavior (backport #4240) (#4313)

Comment 7

[Vlad Dreghici [:vdreghici]]

Comment on attachment 9361394 [details] [review]
[mozilla-mobile/firefox-android] Bug 1859913 - Revert shopping CFR behavior (backport #4240) (#4313)

Beta/Release Uplift Approval Request

• User impact if declined: If declined, the Shopping CFR will not be dismissible by back press or outside touch.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Same steps as stated for nightly.
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change is not risky because we only enabled to ability to dismiss the CFR by tapping outside or pressing back. By default, these settings were false, but due to UX requirement, this will be true only for Shopping CFR for now.
• String changes made/needed: none
• Is Android affected?: Yes

Comment 8

[Dianna Smith [:diannaS]]

Comment on attachment 9361394 [details] [review]
[mozilla-mobile/firefox-android] Bug 1859913 - Revert shopping CFR behavior (backport #4240) (#4313)

Approved for Mobile 120.0b5

Comment 9

[BMO Github Automation]

Authored by https://github.com/DreVla
https://github.com/mozilla-mobile/firefox-android/commit/31fe6d7c148ceb5ba4f268ba2bf22e830f668c9b
[releases_v120] Bug 1859913 - Revert shopping CFR behavior

Comment 10

[Adina Petridean QA [:apetridean]]

This bug will be verified when the Fakespot feature becomes available in Firefox Beta.

Comment 11

[Adina Petridean QA [:apetridean]]

Verified as fixed on Firefox Beta 120.0b7 from 11/07 with Motorola G9 Plus (Android 11) and Sony Xperia (Android 6.0.1). When taping outside the CFR is dismissed.