1859928 - Update anchor alignment fix of MILESTONE_MESSAGE_87 message on RS

Status: VERIFIED FIXED

(Firefox :: Messaging System, task, P1)

Description

[Punam Dahiya [:pdahiya]]

MILESTONE_MESSAGE_87 is hosted inside CFR bucket on Remote Settings that are launched and updated off-train.

https://www.bugzy.org/rs-messages

https://bugzilla.mozilla.org/show_bug.cgi?id=1830953 fix touched test and dev messages inside tree and needs to be reflected in Remote Settings.

https://mozilla.slack.com/archives/C4D3JFF26/p1683051095366129?thread_ts=1682980787.439959&cid=C4D3JFF26

Scope of this bug is to update MILESTONE_MESSAGE_87 in RS with the anchor alignment fix and respective file in messaging-system-inflight-assets github repo

https://github.com/mozilla/messaging-system-inflight-assets/blob/main/messages/cfr.yaml#L5

Comment 1

[Punam Dahiya [:pdahiya]]

Steps to replicate Milestone message in Firefox outside of devtools:

Preconditions

• Set browser.contentblocking.cfr-milestone.milestones to [15, 30]
• Make sure that browser.contentblocking.cfr-milestone.milestone-achieved is set to 0
• Create and set browser.contentblocking.cfr-milestone.update-interval to 10

Steps to reproduce

1. Visit https://www.reddit.com/
2. Refresh the site for a couple of times until the cookies blocked hit milestone set, i.e. "15" or “30”. This can be checked in Protection panel's UI.

Comment 2

[Punam Dahiya [:pdahiya]]

Attachment: fx120-milestone-anchor-to-tracking-icon-box.png

Comment 3

[Punam Dahiya [:pdahiya]]

Attachment: fx120-milestone-anchor-tracking-icon-container.png

Comment 4

[Punam Dahiya [:pdahiya]]

Milestone message gets about ~100k impressions per day (maximum impressions from last 5 releases ). Most recently in Fx119 UI got regressed by changes in tree (bug 1860898). To rollout fix of bug 1830953 and easy future updates of live message we should

a) Update MILESTONE_MESSAGE_87 hosted on RS with fix of 1830953 (anchor_id as "tracking-protection-icon-container) and targeting as pageLoad >= 4 && firefoxVersion >= 115 && firefoxVersion < 121 && userPrefs.cfrFeatures

https://github.com/mozilla/messaging-system-inflight-assets/blob/main/messages/cfr.yaml#L63

This will stop showing MILESTONE_MESSAGE_87 message on version prior to Fx115 which is a very small percentage of impressions https://mozilla.cloud.looker.com/looks/1696?toggle=dat,fil,pik

b) With Fx121, graduate MILESTONE_MESSAGE_87 making it part of Firefox by adding it as one of the BASE_MESSAGES in OnboardingMessageProvider having targeting as pageLoad >= 4 && userPrefs.cfrFeatures

https://searchfox.org/mozilla-central/rev/ffdc4971dc18e1141cb2a90c2b0b776365650270/browser/components/newtab/lib/OnboardingMessageProvider.jsm#56

Comment 5

[Punam Dahiya [:pdahiya]]

NI Product for feedback about the proposed update in #comment 4 thanks!

Comment 6

[Vtay]

Yes we can update.

I'll put it on my to do to sync with the felt privacy team to determine if these messages have any impact on our users.

Comment 7

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1859928 - Add MILESTONE_MESSAGE_87 to OnboardingMessageProvider

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3281b725e71
Add MILESTONE_MESSAGE_87 to OnboardingMessageProvider r=omc-reviewers,aminomancer

Comment 9

[Punam Dahiya [:pdahiya]]

(In reply to Vtay from comment #6)

Yes we can update.

I'll put it on my to do to sync with the felt privacy team to determine if these messages have any impact on our users.

Thanks @vtay , as updated in #comment 4 fix of https://github.com/mozilla/messaging-system-inflight-assets/pull/254/files will stop showing MILESTONE_MESSAGE_87 on versions before Fx115 which as per below metrics is a very small number

https://mozilla.cloud.looker.com/looks/1696?toggle=dat,fil,pik

Comment 10

[Ed Lee :Mardak]

The glean data used in that look only started in 115 with bug 1825863. Under 115 is less than 5% in the past month.

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/c3281b725e71

Comment 12

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this task and I can confirm the following:

• The "anchor_id" of the "MILESTONE_MESSAGE_87" is set to "tracking-protection-icon-container".
• The message targeting is set to "pageLoad >= 4 && userPrefs.cfrFeatures"

Verified using the latest Firefox Nightly 121.0a1 (Build ID: 20231101200218) installed on Windows 10 x64, macOS 13.4.1, and Linux Mint 21.1.