1859997 - Reading toml manifests is slow

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Mike Hommey [:glandium]]

See bug 1821199 comment 3 and 4.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1859997 - Switch manifestparser to toml instead of tomlkit.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1779473

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1779473

Comment 4

[Andrew Halberstadt [:ahal]]

This is also impacting decision task performance, which is starting to rise in priority.

Tom, just flagging https://phabricator.services.mozilla.com/D191394#6351714 in case you missed it. It outlines how we can proceed with tomlkit as a runtime dependency. We'll need a patch that uses it conditionally when some flag is passed (e.g --preserve-comments or something).

Comment 5

[Tom Marble]

@ahal I have reviewed your phab and accept it.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ff55ad72883
Switch manifestparser to toml instead of tomlkit. r=jmaher,ahal,mach-reviewers

Comment 7

[Atila Butkovits]

Backed out for causing python related mass failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/7328a3487fd3de44c89f40ab4aaa39f34468f578

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=HY9BSMNdSnOLT_swdcKgQg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=7ff55ad728833b72672c3016ea11f8a767ffbe72

Failure log: https://treeherder.mozilla.org/logviewer?job_id=433671066&repo=autoland&lineNumber=2051

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e17da829b210
Switch manifestparser to toml instead of tomlkit. r=jmaher,ahal,mach-reviewers

Comment 9

[Cristina Horotan [:chorotan]]

Backed out changeset e17da829b210 (bug 1859997) for causing mochitest failures at test_docload_shutdown.html

Backout: https://hg.mozilla.org/integration/autoland/rev/99f1297a102b4c1fc2156cbc8b49be4856cce481

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=osx%2Ca11y%2C&revision=e17da829b210893c021856c21de6ac08afb8ca73&selectedTaskRun=FZSsMmENSxanliY-WWB6EA.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=433844478&repo=autoland&lineNumber=4541

Comment 10

[Mike Hommey [:glandium]]

Great, it turns out we have the multiline-string syntax in in-tree toml files... https://searchfox.org/mozilla-central/rev/40d51bef58b8e901d6ab4b60dd280f372a0e417d/accessible/tests/mochitest/events/docload/a11y.toml#15

It looks like it's the only file, though.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94cb610c5d84
Switch manifestparser to toml instead of tomlkit. r=jmaher,ahal,mach-reviewers

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/94cb610c5d84

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:glandium, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox120 to wontfix.

For more information, please visit BugBot documentation.