1860161 - Overlay scrollbars on Android do not fade out smoothly

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Description

[Gregory Pappas [:gregp]]

Noticed while working on bug 1859864 that ScrollbarFadeDuration on Android is 0. It seemed a bit odd because every other platform with overlay scrollbars has a non-zero fade duration, but I figured that it was intentional and for power saving/performance/etc.

Looking closer, it seems this is actually a regression from switching away from the old java scrollbars to gecko scrollbars (bug 1223928). The old java scrollbars did fade out (bug 704784).

The fade animation makes scrollbars look nicer imo so it would be cool if we could bring this back.

Chromium uses a duration of 300ms so we should probably match that, since people are used to it.
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/widget/compositing/layer_tree_settings.cc;l=68-84;drc=6d4dcee2c0a7d7750037ffb70de6b82385d7ad0e

Comment 1

[Gregory Pappas [:gregp]]

Attachment: Bug 1860161 - Fade out overlay scrollbars on Android r?emilio!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d59c5fae45bd
Fade out overlay scrollbars on Android r=emilio,geckoview-reviewers,m_kato

Comment 3

[Iulian Moraru]

Backed out for causing wpt failures on keyboard.html.

• Push with failures

• Failure log

• Backout link

[task 2023-10-23T14:41:12.795Z] 14:41:12     INFO - TEST-START | /css/css-scroll-snap/input/keyboard.html
[task 2023-10-23T14:41:12.865Z] 14:41:12     INFO - Setting pref dom.animations-api.compositing.enabled to true
[task 2023-10-23T14:41:16.933Z] 14:41:16     INFO - 
[task 2023-10-23T14:41:16.933Z] 14:41:16     INFO - TEST-PASS | /css/css-logical/logicalprops-with-variables.html | Logical longhands with variables - margin-inline 
[task 2023-10-23T14:41:16.933Z] 14:41:16     INFO - TEST-PASS | /css/css-logical/logicalprops-with-variables.html | Logical shorthand with 1 variable - margin-inline-start 
[task 2023-10-23T14:41:16.933Z] 14:41:16     INFO - TEST-PASS | /css/css-logical/logicalprops-with-variables.html | Logical shorthand with 1 variable - margin-inline-end 
[task 2023-10-23T14:41:16.933Z] 14:41:16     INFO - TEST-PASS | /css/css-logical/logicalprops-with-variables.html | Logical shorthand with 1 variable - margin-inline 
[task 2023-10-23T14:41:16.933Z] 14:41:16     INFO - TEST-PASS | /css/css-logical/logicalprops-with-variables.html | Logical shorthand with 2 variables - margin-inline-start 
[task 2023-10-23T14:41:16.933Z] 14:41:16     INFO - TEST-PASS | /css/css-logical/logicalprops-with-variables.html | Logical shorthand with 2 variables - margin-inline-end 
[task 2023-10-23T14:41:16.933Z] 14:41:16     INFO - TEST-PASS | /css/css-logical/logicalprops-with-variables.html | Logical shorthand with 2 variables - margin-inline 
[task 2023-10-23T14:41:16.933Z] 14:41:16     INFO - TEST-PASS | /css/css-logical/logicalprops-with-variables.html | Logical shorthand with 1 variable and 1 length - margin-inline-start 
[task 2023-10-23T14:41:16.933Z] 14:41:16     INFO - TEST-PASS | /css/css-logical/logicalprops-with-variables.html | Logical shorthand with 1 variable and 1 length - margin-inline-end 
[task 2023-10-23T14:41:16.933Z] 14:41:16     INFO - TEST-PASS | /css/css-logical/logicalprops-with-variables.html | Logical shorthand with 1 variable and 1 length - margin-inline 
[task 2023-10-23T14:41:16.933Z] 14:41:16     INFO - TEST-UNEXPECTED-FAIL | /css/css-scroll-snap/input/keyboard.html | Snaps to bottom-left after pressing ArrowDown - assert_greater_than: expected a number greater than 1 but got 0
[task 2023-10-23T14:41:16.933Z] 14:41:16     INFO - @http://web-platform.test:8000/css/css-scroll-snap/input/keyboard.html:67:22
[task 2023-10-23T14:41:17.014Z] 14:41:17     INFO - TEST-OK | /css/css-scroll-snap/input/keyboard.html | took 4218ms
[task 2023-10-23T14:41:17.402Z] 14:41:17     INFO - STDOUT: cleanup aborted: Unable to remount device
[task 2023-10-23T14:41:17.508Z] 14:41:17     INFO - STDOUT: cleanup aborted: Unable to remount device
[task 2023-10-23T14:41:17.509Z] 14:41:17     INFO - Closing logging queue
[task 2023-10-23T14:41:17.509Z] 14:41:17     INFO - queue closed
[task 2023-10-23T14:41:17.524Z] 14:41:17     INFO - Setting up ssl
[task 2023-10-23T14:41:17.546Z] 14:41:17     INFO - certutil | b''
[task 2023-10-23T14:41:17.566Z] 14:41:17     INFO - certutil | b''
[task 2023-10-23T14:41:17.576Z] 14:41:17     INFO - certutil | b'\nCertificate Nickname                                         Trust Attributes\n                                                             SSL,S/MIME,JAR/XPI\n\nweb-platform-tests                                           CT,, \n'
[task 2023-10-23T14:41:18.211Z] 14:41:18     INFO - adb Granting important runtime permissions to org.mozilla.geckoview.test_runner
[task 2023-10-23T14:41:19.511Z] 14:41:19     INFO - adb launch_application: am start -W -n org.mozilla.geckoview.test_runner/org.mozilla.geckoview.test_runner.TestRunnerActivity -a android.intent.action.MAIN --es env0 MOZ_CRASHREPORTER=1 --es env1 MOZ_CRASHREPORTER_NO_REPORT=1 --es env2 MOZ_CRASHREPORTER_SHUTDOWN=1 --es env3 MOZ_HIDE_RESULTS_TABLE=1 --es env4 MOZ_IN_AUTOMATION=1 --es env5 MOZ_LOG=signaling:3,mtransport:4,DataChannel:4,jsep:4 --es env6 R_LOG_LEVEL=6 --es env7 R_LOG_DESTINATION=stderr --es env8 R_LOG_VERBOSE=1 --es env9 MOZ_PROCESS_LOG=/tmp/tmpw33rj7l3pidlog --es env10 MOZ_DISABLE_NONLOCAL_CONNECTIONS=1 --es arg0 -no-remote --es arg1 -profile --es arg2 /data/local/tmp/test_root/profile --es arg3 --marionette --es arg4 about:blank --ez use_multiprocess True
[task 2023-10-23T14:41:20.886Z] 14:41:20     INFO - Starting runner
[task 2023-10-23T14:41:23.992Z] 14:41:23     INFO - TEST-START | /css/css-scroll-snap/input/snap-area-overflow-boundary.html

Comment 4

[Gregory Pappas [:gregp]]

Errr, hmm. I can't reproduce this failure locally... :/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aaa658ba6ff7
Fade out overlay scrollbars on Android r=emilio,geckoview-reviewers,m_kato

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/aaa658ba6ff7

Comment 7

[Chris Peterson [:cpeterson]]

No need to uplift to Beta 120.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1223928