1860185 - Refactor JSON.parse implementation to match current spec

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Bryan Thrall [:bthrall]]

The JSON.parse implementation reflects the ES5 spec.

To make it easier to make changes in the future, we should refactor the implementation to reflect the current spec.

The code comments should reference the current spec section and headers.
Where possible, without hurting performance, the code structure should also reflect the algorithms in the spec (including variable names, function names, data flow, etc.).

Comment 1

[Bryan Thrall [:bthrall]]

Attachment: Bug 1860185 - Sync JSON.parse spec references to ECMA-262 spec 14th ed. r=jandem

Comment 2

[Bryan Thrall [:bthrall]]

Attachment: Bug 1860185 - Sync JSON.stringify spec references to ECMA-262 spec 14th ed. r=jandem

Depends on D191774

Comment 3

[Bryan Thrall [:bthrall]]

Attachment: Bug 1860185 - Rename InternalizeJSONProperty r=jandem

Depends on D191775

Comment 4

[Bryan Thrall [:bthrall]]

Attachment: Bug 1860185 - Rename SerializeJSONObject and SerializeJSONArray r=jandem

Depends on D191776

Comment 5

[Bryan Thrall [:bthrall]]

Attachment: Bug 1860185 - Rename SerializeJSONProperty and FastSerializeJSONProperty r=jandem

Depends on D191777

Comment 6

[Bryan Thrall [:bthrall]]

Attachment: Bug 1860185 - Rename QuoteJSONString, QuoteJSONStringHelper, InfallibleQuoteJSONString r=jandem

Depends on D191778

Comment 7

[Bryan Thrall [:bthrall]]

The code structure already resembled the spec algorithms, with exceptions for performance. I did need to rename a few methods to better mach the spec, but none of the differences in variable names seemed significant enough to need updating.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28ba90bd58a2
Sync JSON.parse spec references to ECMA-262 spec 14th ed. r=jandem
https://hg.mozilla.org/integration/autoland/rev/7e2c4ed96bb1
Sync JSON.stringify spec references to ECMA-262 spec 14th ed. r=jandem
https://hg.mozilla.org/integration/autoland/rev/a90002692362
Rename InternalizeJSONProperty r=jandem
https://hg.mozilla.org/integration/autoland/rev/1f12fb871f48
Rename SerializeJSONObject and SerializeJSONArray r=jandem
https://hg.mozilla.org/integration/autoland/rev/3192598920b3
Rename SerializeJSONProperty and FastSerializeJSONProperty r=jandem
https://hg.mozilla.org/integration/autoland/rev/897b39f9148a
Rename QuoteJSONString, QuoteJSONStringHelper, InfallibleQuoteJSONString r=jandem

Comment 9

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/28ba90bd58a2
https://hg.mozilla.org/mozilla-central/rev/7e2c4ed96bb1
https://hg.mozilla.org/mozilla-central/rev/a90002692362
https://hg.mozilla.org/mozilla-central/rev/1f12fb871f48
https://hg.mozilla.org/mozilla-central/rev/3192598920b3
https://hg.mozilla.org/mozilla-central/rev/897b39f9148a