1860205 - CSS round(up, A, B) and round(down, A, B) order of operations incorrect (A multiplied by -1 before rounding)

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[firefoxbugs]

Steps to reproduce:

In addition to bug 1859048, the CSS round() function produces wrong answers when combined with further calculations.
examples:
calc(0px - round(up, 1.9px, 1px))
calc(0px - round(down, 1.1px, 1px))

Actual results:

The first yields -1px.
The second yields -2px.

Expected results:

Obviously, the first should be -2px and the second should be -1px.

Somehow it seems like the values are escaping parentheses and being evaluated out of order.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jfkthame, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1860205 - Swap Up/Down rounding strategy when negating a Round calc node. r=#style

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1860205 - Add tests for negation of a round() node. r=#style

Depends on D192742

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db7079f00408
Swap Up/Down rounding strategy when negating a Round calc node. r=firefox-style-system-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/e7a1cc464f70
Add tests for negation of a round() node. r=firefox-style-system-reviewers,emilio

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/db7079f00408
https://hg.mozilla.org/mozilla-central/rev/e7a1cc464f70

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/42962 for changes under testing/web-platform/tests

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot