Closed
Bug 1860230
Opened 1 year ago
Closed 1 year ago
nsComponentManagerUtils.cpp: duplicate include "nsComponentManager.h"
Categories
(Core :: XPCOM, task)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
121 Branch
| Tracking | Status | |
|---|---|---|
| firefox121 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: nagata.parama, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=c++])
Attachments
(2 files)
|
7.41 KB,
patch
|
Details | Diff | Splinter Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review |
Filling as a good first bug to learn workflows.
https://searchfox.org/mozilla-central/source/xpcom/components/nsComponentManagerUtils.cpp#24
duplicate include on "nsComponentManager.h"
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html
|
||
Comment 1•1 year ago
|
||
|
Reporter | |
Comment 2•1 year ago
|
||
we don't use bugzilla for code review. please use phabricator
see
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
|
Assignee | |
Comment 3•1 year ago
|
||
|
||
Updated•1 year ago
|
Assignee: nobody → nagata.parama
Status: NEW → ASSIGNED
|
|
||
Updated•1 year ago
|
Attachment #9360852 -
Attachment description: Bug 1860230 - Move offending include into its own ifdef. r?Sylvestre → Bug 1860230 - nsComponentManagerUtils.cpp: Only include "nsComponentManager.h" once r?Sylvestre
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b37583fe73c1
nsComponentManagerUtils.cpp: Only include "nsComponentManager.h" once r=sylvestre DONTBUILD
|
||
Comment 5•1 year ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox121:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 121 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•