1860232 - ModuleEnvironmentProxy.cpp: duplicate include "PropertyDescriptor.h"

Status: RESOLVED FIXED

(Core :: XPConnect, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

https://searchfox.org/mozilla-central/source/js/xpconnect/loader/ModuleEnvironmentProxy.cpp#20

 duplicate include on "PropertyDescriptor.h"

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Comment 1

[andreas221b]

Hi I'm new to the community, I can work on that.
I'll try to build the project locally and fix it to get familiar with the workflows.

Comment 2

[andreas221b]

Attachment: Bug 1860232 - Removes duplicate include r?Sylvestre

Removes duplicate include of PropertyDescriptor.h
in ModuleEnvironmentProxy.cpp

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/991f4ed14c59
Removes duplicate include r=sylvestre DONTBUILD

Comment 4

[Massa B. Tamfu]

Attachment: Bug 1860232 ModuleEnvironmentProxy.cpp: removed duplicate include "PropertyDescriptor.h"

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/991f4ed14c59

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 9360520 [details]
Bug 1860232 ModuleEnvironmentProxy.cpp: removed duplicate include "PropertyDescriptor.h"

we use phabricator for code review
do you want another good first bug?

Comment 7

[andreas221b]

Yes, I was actually about to ask. You can suggest another one, good first or smth little more complicated..
Do I need to do anything more on Phabricator? I far as I read, will be done automatically..