1860377 - Paint overlapping selections

Status: RESOLVED FIXED

(Core :: Layout, enhancement)

Description

[Jan Jaeschke [:jjaschke]]

New features such as Custom Highlight API or Text Fragments internally use new selection types for displaying ranges. This leads to situations where a text range is part of multiple selections. If these selections are not opaque, the colors should be mixed.

Currently, the selection painting mechanism in nsTextFrame only considers the selection with the highest priority for each text section and paints it.
This can be solved by painting each selection in a loop.

Comment 1

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1860377: Allow selections of different kind to overlap visually. r=emilio!

Since features such as Custom Highlight API or ::target-text are implemented
as a selection, multiple selections can be present on a section of text.

This patch paints all selections ordered by their priority instead of only painting the top-priority one,
so that colors will be combined if selections are not opaque.

Comment 2

[Jan Jaeschke [:jjaschke]]

Here's a try run.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e91ccb036dc
Allow selections of different kind to overlap visually. r=emilio

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/5e91ccb036dc

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/42819 for changes under testing/web-platform/tests

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot