1860425 - Consider dropping support for numeric time zones without "GMT" prefix in Date.parse

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, defect, P2)

Description

[Vinny Diehl]

We currently support time zone formats such as "-04" as opposed to "GMT-04", which are rejected by both Chrome and Safari:

> eshost -te 'new Date("12-Mar-2022 -04")'

Engine	Result
JavaScriptCore	Invalid Date
SpiderMonkey	Fri Mar 11 2022 21:00:00 GMT-0700 (Mountain Standard Time)
V8	Invalid Date

While these formats are reasonable to support, we might consider dropping support for webcompat purposes.

Comment 1

[Vinny Diehl]

Before I or someone else begins work on this, do you agree with this change, :arai?

Comment 2

[Tooru Fujisawa [:arai]]

Looks like this is specific to when the input has no "time" part.
If hh:mm part is provided, JavaScriptCore and V8 accept them.
Firefox accepts them except for +04 without space.
If there's only hh, no browser accepts.

	JavaScriptCore	SpiderMonkey	V8
"12-Mar-2022 00:00:00-04"	OK	OK	OK
"12-Mar-2022 00:00:00 -04"	OK	OK	OK
"12-Mar-2022 00:00:00+04"	OK	ERR	OK
"12-Mar-2022 00:00:00 +04"	OK	OK	OK
"12-Mar-2022 00:00-04"	OK	OK	OK
"12-Mar-2022 00:00 -04"	OK	OK	OK
"12-Mar-2022 00:00+04"	OK	ERR	OK
"12-Mar-2022 00:00 +04"	OK	OK	OK
"12-Mar-2022 00-04"	ERR	ERR	ERR
"12-Mar-2022 00 -04"	ERR	ERR	ERR
"12-Mar-2022 00+04"	ERR	ERR	ERR
"12-Mar-2022 00 +04"	ERR	ERR	ERR

So, I agree with rejecting the "12-Mar-2022 -04" format, but it's better keep accepting when hh:mm are give.
and also optionally align with other browser for +04 without space.

Comment 3

[Vinny Diehl]

Attachment: Bug 1860425 - Adjust parsing for timezone numbers without "GMT" prefix r?arai

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46326a19988d
Adjust parsing for timezone numbers without "GMT" prefix r=arai

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/46326a19988d