Closed Bug 1860508 Opened 1 year ago Closed 9 months ago

Remove exclusion of eslint-visitor-keys from ESLint setup once Babel updates its dependency

Categories

(Developer Infrastructure :: Lint and Formatting, task)

Product:
Developer Infrastructure
Component:
Lint and Formatting
Type:
task

Tracking

(firefox124 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox124 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Our ESLint setup routine has code in place to check to see if any of the dependencies are outdated and then run npm ci if necessary.

In bug 1766268 we changed the code to skip eslint-plugin-mozilla's (e-p-m) dependencies due to an issue with Babel shipping an out of date version of eslint-visitor-keys, compared to what we needed for e-p-m.

In bug 1766659 I am refining that to only skip checking of eslint-visitor-keys rather than all of e-p-m.

Currently, we need to wait until Babel 8 ships before we can hopefully resolve this - they're not planning on updating their dependency on that module until then, due to potentially breaking changes.

Depends on: 1878009

Fixed by bug 1878009.

Assignee: nobody → standard8
Status: NEW → RESOLVED
Closed: 9 months ago
status-firefox124: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.