1860801 - With the no-readback webgpu enabled, crash if you close a webgpu demo in the background tab

Status: VERIFIED FIXED

(Core :: Graphics: WebGPU, defect, P2)

Description

[Mayank Bansal]

Use latest nightly which has the patches for bug 1856787
Set dom.webgpu.swap-chain.external-texture-dx12=True . Restart the browser
Go to bug https://bugzilla.mozilla.org/show_bug.cgi?id=1850206
Open the linked webgpu demo in a new tab
Switch to the new tab and keep that tab open for a few seconds . Let the demo run.
Go back to the previous tab and close the demo tab (middle click on the demo tab or right click->Close tab)

AR: Browser flashes
ER: not so?

I get crashes liek this : https://crash-stats.mozilla.org/report/index/26abcc9e-fcc9-43d9-9071-36d7e0231024

Comment 1

[Mayank Bansal]

This is technically not a regression as the no-readback thingy is not fully developed yet. But marking as regression just for tracking. Feel free to track otherwise.

Comment 2

[Mayank Bansal]

Attachment: about:support

Comment 3

[Mayank Bansal]

Attachment: about:support after the crash

Comment 4

[Mayank Bansal]

Similarish crash also occurs if you tear the demo tab.

Comment 5

[Sotaro Ikeda [:sotaro]]

Thank you for the report. I take the bug.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1856787

Comment 7

[Mayank Bansal]

Another aspect of this is that playing GIFs in teh current tab will stop running if this crash occurs.

STR:

1. Go to https://github.com/kishimisu/WebGPU-Fluid-Simulation
2. Scroll down a bit to the readme. There is a beautiful GIF of the demo.
3. Now open the actual demo (https://kishimisu.github.io/WebGPU-Fluid-Simulation/) in a new tab and switch to it for 5 seconds
4. Switch back to the github tab with the GIF, and close the demo tab by middle-clicking it by mouse.

AR: The GIF stops playing, may turn white. But it wont recover and start playing normally. Other "moving" things like youtube videos or CSS animations recover almost immediately.

Let me know if you prefer a new bug for this.

Comment 8

[Sotaro Ikeda [:sotaro]]

Crash occurred when TextureRaw's d3d12::Resource was destroyed after gpu_server_delete().

Comment 9

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1860801 - Remove caching d3d12::Resource in TextureRaw

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8fc46c3e9e1
Remove caching d3d12::Resource in TextureRaw r=lsalzman

Comment 11

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/d8fc46c3e9e1

Comment 12

[Mayank Bansal]

Fixed on the latest Nightly. Thanks!

Comment 13

[Ina Popescu, Desktop QA]

I've reproduced this issue in Nightly 121.0a1 (2023-10-24) on Windows10 x64 following the STR from Comment 0.
Verified as fixed in the latest Firefox 121.0b7 version on Windows10 x64, Ubuntu 22.04 and macOS 13 where the issue no longer persists.