Open Bug 1860874 Opened 2 years ago Updated 2 years ago

[wpt-sync] Sync PR 42727 - Allow InvokeEvent action to be explicitly empty.

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 42727 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/42727
Details from upstream follow.

Keith Cirkel <chromium@keithcirkel.co.uk> wrote:

Allow InvokeEvent action to be explicitly empty.

This follows the feedback from @smaug on the firefox implementation

https://phabricator.services.mozilla.com/D190449#inline-1063065 :

This is unexpected. If empty string is pass, action should stay
empty. If we want "auto" to be the default value, then "auto"
should be used in webidl. But even then if one explicitly passes
empty string, then the value should stay empty, that is how event
interfaces work.

Bug: 1495475
Change-Id: Ic96f649ec49531c0eb5419153c0b46a35a44810a

Reviewed-on: https://chromium-review.googlesource.com/4974275
WPT-Export-Revision: 844b00c4bd0db363d8770ab84013d99f729557b8

PR 42727 applied with additional changes from upstream: ff48f1e16f44d32e1805a085342c197a4966b66c
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 22 subtests

Status Summary

Firefox

OK : 3
PASS: 6
FAIL: 46

Chrome

OK : 3
PASS: 6
FAIL: 46

Safari

OK : 3
PASS: 6
FAIL: 46

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /html/semantics/invokers/idlharness.tentative.html [wpt.fyi]
    • InvokeEvent interface: existence and properties of interface object: FAIL (Chrome: FAIL, Safari: FAIL)
    • InvokeEvent interface object length: FAIL (Chrome: FAIL, Safari: FAIL)
    • InvokeEvent interface object name: FAIL (Chrome: FAIL, Safari: FAIL)
    • InvokeEvent interface: existence and properties of interface prototype object: FAIL (Chrome: FAIL, Safari: FAIL)
    • InvokeEvent interface: existence and properties of interface prototype object's "constructor" property: FAIL (Chrome: FAIL, Safari: FAIL)
    • InvokeEvent interface: existence and properties of interface prototype object's @@unscopables property: FAIL (Chrome: FAIL, Safari: FAIL)
    • InvokeEvent interface: attribute invoker: FAIL (Chrome: FAIL, Safari: FAIL)
    • InvokeEvent interface: attribute action: FAIL (Chrome: FAIL, Safari: FAIL)
    • InvokeEvent must be primary interface of new InvokeEvent("invoke"): FAIL (Chrome: FAIL, Safari: FAIL)
    • Stringification of new InvokeEvent("invoke"): FAIL (Chrome: FAIL, Safari: FAIL)
    • InvokeEvent interface: new InvokeEvent("invoke") must inherit property "invoker" with the proper type: FAIL (Chrome: FAIL, Safari: FAIL)
    • InvokeEvent interface: new InvokeEvent("invoke") must inherit property "action" with the proper type: FAIL (Chrome: FAIL, Safari: FAIL)
  • /html/semantics/invokers/invokeelement-interface.tentative.html [wpt.fyi]
    • invokeTargetElement reflects invokee HTML element: FAIL (Chrome: FAIL, Safari: FAIL)
    • invokeTargetElement reflects set value: FAIL (Chrome: FAIL, Safari: FAIL)
    • invokeTargetElement reflects set value across shadow root into light dom: FAIL (Chrome: FAIL, Safari: FAIL)
    • invokeTargetElement does not reflect set value inside shadowroot: FAIL (Chrome: FAIL, Safari: FAIL)
    • invokeTargetElement throws error on assignment of non Element: FAIL (Chrome: FAIL, Safari: FAIL)
    • invokeAction reflects 'auto' when attribute not present: FAIL (Chrome: FAIL, Safari: FAIL)
    • invokeAction reflects 'auto' when attribute empty: FAIL (Chrome: FAIL, Safari: FAIL)
    • invokeAction reflects same casing: FAIL (Chrome: FAIL, Safari: FAIL)
    • invokeAction reflects 'auto' when attribute empty 2: FAIL (Chrome: FAIL, Safari: FAIL)
    • invokeAction reflects tostring value: FAIL (Chrome: FAIL, Safari: FAIL)
    • invokeAction reflects 'auto' when attribute set to []: FAIL (Chrome: FAIL, Safari: FAIL)
    • invokeAction reflects tostring value 2: FAIL (Chrome: FAIL, Safari: FAIL)
  • /html/semantics/invokers/invokeevent-interface.tentative.html [wpt.fyi]
    • action is a readonly defaulting to 'auto': FAIL (Chrome: FAIL, Safari: FAIL)
    • invoker is readonly defaulting to null: FAIL (Chrome: FAIL, Safari: FAIL)
    • action reflects initialized attribute: FAIL (Chrome: FAIL, Safari: FAIL)
    • action set to undefined: FAIL (Chrome: FAIL, Safari: FAIL)
    • action set to null: FAIL (Chrome: FAIL, Safari: FAIL)
    • action set to false: FAIL (Chrome: FAIL, Safari: FAIL)
    • action explicitly set to empty string: FAIL (Chrome: FAIL, Safari: FAIL)
    • action set to true: FAIL (Chrome: FAIL, Safari: FAIL)
    • action set to a number: FAIL (Chrome: FAIL, Safari: FAIL)
    • action set to []: FAIL (Chrome: FAIL, Safari: FAIL)
    • action set to [1, 2, 3]: FAIL (Chrome: FAIL, Safari: FAIL)
    • action set to an object: FAIL (Chrome: FAIL, Safari: FAIL)
    • action set to an object with a toString function: FAIL (Chrome: FAIL, Safari: FAIL)
    • InvokeEventInit properties set value: FAIL (Chrome: FAIL, Safari: FAIL)
    • InvokeEventInit properties set value 2: FAIL (Chrome: FAIL, Safari: FAIL)
    • InvokeEventInit properties set value 3: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoker set to undefined: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoker set to null: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoker set to false: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoker set to true: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoker set to {}: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoker set to non-Element EventTarget: FAIL (Chrome: FAIL, Safari: FAIL)
You need to log in before you can comment on or make changes to this bug.