1860889 - Implement JSON.rawJSON and JSON.isRawJSON functions

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Bryan Thrall [:bthrall]]

Implement the JSON.rawJSON() and JSON.isRawJSON() functions, protected behind the shell option that enables the JSON.parse with source proposal.

Comment 1

[Bryan Thrall [:bthrall]]

Attachment: Bug 1860889 - Support JSON.rawJSON() and JSON.isRawJSON() r=jandem,dminor

Comment 2

[Bryan Thrall [:bthrall]]

Attachment: Bug 1860889 - Report SyntaxErrors from JSON.rawJSON() r=jandem,dminor

The function IsJSONWhitespace() also appears in JSONParser.cpp, but at this
point it doesn't seem worth the effort of deduplicating it.

Comment 3

[Bryan Thrall [:bthrall]]

Attachment: Bug 1860889 - Enable test262 tests for JSON.parse with source r=jandem,dminor

Comment 4

[Bryan Thrall [:bthrall]]

Attachment: Bug 1860889 - Remove build config for JSON.parse with source r=jandem,dminor

It should only be available (via a pref) in Nightly, now.

Skip the non262 test in browser reftests because that's what other tests that
require setting a preference do. We should enable it when we remove the
preference.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3614bce991ac
Support JSON.rawJSON() and JSON.isRawJSON() r=jandem
https://hg.mozilla.org/integration/autoland/rev/0f5d6ecc7a9f
Report SyntaxErrors from JSON.rawJSON() r=jandem
https://hg.mozilla.org/integration/autoland/rev/2267e7765e87
Remove build config for JSON.parse with source r=jandem
https://hg.mozilla.org/integration/autoland/rev/5129e0aba202
Enable test262 tests for JSON.parse with source r=mgaudet

Comment 6

[Atila Butkovits]

Backed out for causing build bustages at GCHashTable.h.

Backout link: https://hg.mozilla.org/integration/autoland/rev/9e5ae590250a9fb06dc656cf77179c2531ee328d

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=c82ea4f23c921fea9bcd2cd7f2361e0831710f25

Failure log: https://treeherder.mozilla.org/logviewer?job_id=451516709&repo=autoland&lineNumber=32887

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50d4cdecac19
Support JSON.rawJSON() and JSON.isRawJSON() r=jandem
https://hg.mozilla.org/integration/autoland/rev/b0f251a4bb8f
Report SyntaxErrors from JSON.rawJSON() r=jandem
https://hg.mozilla.org/integration/autoland/rev/07a8dbfb23ae
Remove build config for JSON.parse with source r=jandem
https://hg.mozilla.org/integration/autoland/rev/82c125858029
Enable test262 tests for JSON.parse with source r=mgaudet

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/50d4cdecac19
https://hg.mozilla.org/mozilla-central/rev/b0f251a4bb8f
https://hg.mozilla.org/mozilla-central/rev/07a8dbfb23ae
https://hg.mozilla.org/mozilla-central/rev/82c125858029