1860936 - [wpt-sync] Sync PR 42737 - Paint background invalidation when a table column span changes

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 42737 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/42737
Details from upstream follow.

Andreu Botella <[e-mail]> wrote:

Paint background invalidation when a table column span changes

Although table column elements (LayoutNGTableColumn) are not laid
out, their background styles will affect the background of the table
columns they span. The set of table columns that a table column
element spans can change, which means the background of the table
might need to change when a LayoutNGTableColumn's span changes.

However, this is not currently happening because changing the span is
not invalidating the table background. This patch fixes that. As an
optimization, we invalidate the background only if some of the table's
LayoutNGTableColumn have a CSS-specified background.

For this optimization, however, LayoutNGTable::HasBackgroundForPaint
cannot be used, because that will only take into account the
backgrounds of any LayoutNGTableColumns that span actual columns.
It is possible for a LayoutNGTableColumn that did not span any table
columns to suddenly do so if the span for some previous
LayoutNGTableColumn is decreased. Therefore, we added a new
LayoutNGTable::HasColumnsWithBackground method that checks every
LayoutNGTableColumn.

Bug: 1373252
Change-Id: I05edf22e5709ce33c574dfbe5f4f1c0da62f3a38
Reviewed-on: https://chromium-review.googlesource.com/4974436
WPT-Export-Revision: cef97701a31d9d7ce39666392892e00c8e5c15b6

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=403d3af32239374195e85b958869874e8bdfbf2f

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 2

Chrome

FAIL: 2

Safari

FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91d0b7fb88c5
[wpt PR 42737] - Paint background invalidation when a table column span changes, a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2b18aec1b5a
[wpt PR 42737] - Paint background invalidation when a table column span changes, a=testonly

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c2b18aec1b5a