1860957 - Embedded Spotify does not get the storage access anymore

Status: RESOLVED DUPLICATE of bug 1858143

(Core :: Privacy: Anti-Tracking, defect, P2)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

The console log from the shim when I click the play button:

When using the Spotify embedded player, Firefox calls the Storage Access API on behalf of the site. See https://bugzilla.mozilla.org/show_bug.cgi?id=1792395 for details. spotify-embed.js:114:11
Partitioned cookie or storage access was provided to “https://open.spotify.com/embed/track/29m9hdcziVa1g3FrXtdNOe?utm_source=oembed&autoplay=1&auto_play=1” because it is loaded in the third-party context and dynamic state partitioning is enabled.

Requesting storage access. https://open.spotify.com spotify-embed.js:60:11
Storage access granted for origin “https://open.spotify.com” on “(...)”.
Reloading after storage access grant. spotify-embed.js:70:15
When using the Spotify embedded player, Firefox calls the Storage Access API on behalf of the site. See https://bugzilla.mozilla.org/show_bug.cgi?id=1792395 for details. spotify-embed.js:114:11
Partitioned cookie or storage access was provided to “https://open.spotify.com/embed/track/29m9hdcziVa1g3FrXtdNOe?utm_source=oembed&autoplay=1&auto_play=1” because it is loaded in the third-party context and dynamic state partitioning is enabled.

Clicked play after storage access grant. spotify-embed.js:97:15

1. This happens every time I play in the embedded iframe; previously it was sufficient to have this step only once. (Edit: during mozregression the green builds still did refresh for each iframe, so I might be wrong)
2. It doesn't get the storage access anyway; document.hasStorageAccess() returns false inside the iframe after refresh. That's weird, because before the refresh document.requestStorageAccess() does resolve.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

mozregression points to bug 1835907.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1835907

:bvandersloot, since you are the author of the regressor, bug 1835907, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Paul Zühlcke [:pbz]]

Ben, could we just add another requestStorageAccess call here? That's after frame reload, after the storage access grant.

Comment 4

[Benjamin VanderSloot [:bvandersloot]]

(In reply to Paul Zühlcke [:pbz] from comment #3)

Ben, could we just add another requestStorageAccess call here? That's after frame reload, after the storage access grant.

I think so, but haven't tested to confirm yet. It may also be fixed by https://phabricator.services.mozilla.com/D190577 landing.

Comment 5

[Benjamin VanderSloot [:bvandersloot]]

After testing, either adding that storage access call or landing that patch resolve the issue.

Should we take any action to uplift or allowlist in some way, or just fix it and let it ride the trains with Fx121.

Comment 6

[Paul Zühlcke [:pbz]]

Thanks for taking a look!

I think we can wait for your patch to land and ride the trains. It's partial breakage (preview still works) and can be worked around by disabling ETP via toggle. Also the folks from Spotify are already aware of the issue.

Comment 7

[Kagami Rosylight [:saschanaz] (they/them)]

This works now, thanks! And indeed mozregression points to bug 1858143 as the fixer.