1861195 - Display a progress bar while (re)analysis is in progress

Status: VERIFIED FIXED

(Firefox :: Shopping, task, P2)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

We'd like to show a progress bar that fills in based on the API responses.

The analysis progress info is exposed by the analysis_status API, see the info in the docs[1].

It might be worth splitting out a bug to make sure the progress is returned to the UI code while we're polling for results, and a separate bug (this one?) to implement the UI based on the progress info.

[1] https://docs.google.com/document/d/1eppEnQKrSKavM3qmlm36WG7y8o2ggm-oxugnoSr2tpw/edit#heading=h.wooolubprsl4

Comment 1

[Amy Churchwell [:amy]]

https://www.figma.com/file/Wu4kaHSfKSQnzkym7qek3R/Review-Checker-Spec?type=design&node-id=1-265&mode=design&t=lPUIlEeAygDN8LrQ-0

Comment 2

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Kicking out to 122 as this arrived late in the 121 cycle

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1861195 - add string for progress display in shopping sidebar during (re)analysis, r?niklas!

Comment 4

[Fred Chasen [:fchasen]]

Attachment: Bug 1861195 - Pass analysis progress from pollForAnalysisCompleted and display progress in sidebar message. r=#shopping-reviewers

Makes the ShoppingProduct extend EventEmitter and emit an analysis-progress event when the is progress reported during polling for analysis statuses.

Passes that event down to shopping message bar with a progress attribute.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4b55effdb4b
add string for progress display in shopping sidebar during (re)analysis, r=niklas,fluent-reviewers

Comment 6

[:Gijs (he/him)]

FWIW, the downloads bits live here: https://searchfox.org/mozilla-central/rev/766a338d53cd29e9851107f9e6a62d333c7d2c51/browser/themes/shared/downloads/indicator.css#80 and use a conic-gradient with a CSS variable to show the progress.

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/c4b55effdb4b

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c491ec0fb8f3
Pass analysis progress from pollForAnalysisCompleted and display progress in sidebar message. r=shopping-reviewers,kpatenio

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c491ec0fb8f3

Comment 10

[:Gijs (he/him)]

We normally leave the target milestone field to reflect what branch the fix originally landed in, even if we uplift. :-)

Comment 11

[Fred Chasen [:fchasen]]

Comment on attachment 9363997 [details]
Bug 1861195 - Pass analysis progress from pollForAnalysisCompleted and display progress in sidebar message. r=#shopping-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: The user will be unable to tell how far along in the ~60 review checker analysis generation they are.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Low risk as this changes the icon for the analysis message of the Review Checker, which is only enabled for a small amount of users currently.
• String changes made/needed:
• Is Android affected?: No

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9363997 [details]
Bug 1861195 - Pass analysis progress from pollForAnalysisCompleted and display progress in sidebar message. r=#shopping-reviewers

Approved for 121.0b5.

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/2884c362a51a

Comment 14

[Rares Doghi, Desktop QA]

The analysis progress % is properly displayed in Beta 121.0b5 as well as our latest Nightly build. Verified as fixed.