1861253 - Select color no longer affects dropdown arrow color.

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Lenni]

Attachment: index.html

Steps to reproduce:

Make a simple HTML file with a <select> element.

Give the select element a "color" property of "white" and a "background-color" property of "black".

Give the element the -webkit-text-fill-color: currentcolor property

Actual results:

The arrow stays grey -> not visible anymore

Expected results:

The arrow should follow the color property when using currentcolor. Currentcolor is also the initial default value, so the arrow should always follow the color value even without this property explicitly set.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1849793

:emilio, since you are the author of the regressor, bug 1849793, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1861253 - Draw select's menulist arrow in the select's color. r=dholbert,#layout

In the regressing bug 1849793 I removed a hunk like this because we
don't use any of the parent state on the parent properly:

  if (aAppearance == StyleAppearance::MozMenulistArrowButton) {
    // HTML select and XUL menulist dropdown buttons get state from the
    // parent.
    nsIFrame* parentFrame = aFrame->GetParent();
    aFrame = parentFrame;
    elementState = GetContentState(parentFrame, aAppearance);
  }

However that aFrame = parentFrame also changed the frame we read the
color for the fill. This is not an issue for menus because those don't
override the colors, but for the select menulist button we need to
explicitly inherit.

Comment 3

[Daniel Holbert [:dholbert]]

Maybe worth uplifiting to 120beta, given that this was a new regression shipped in 119 and we're early in the beta cycle?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd29bee48c0c
Draw select's menulist arrow in the select's color. r=dholbert

Comment 6

[Donal Meehan [:dmeehan]]

If it's low risk and :emilio agrees, then we can aim to include this in a 119 dot release (scheduled dot release planned for 2023-11-07)
This just needs a beta and release uplift request once it sticks in central.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9360485 [details]
Bug 1861253 - Draw select's menulist arrow in the select's color. r=dholbert,#layout

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial CSS tweak.
• String changes made/needed: none
• Is Android affected?: Yes

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/dd29bee48c0c

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9360485 [details]
Bug 1861253 - Draw select's menulist arrow in the select's color. r=dholbert,#layout

Approved for 120.0b4

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/8f8ca76f90b4

Comment 11

[Giorgia Nichita, Release Desktop QA]

Reproduced this issue on an affected Nightly build from 203-10-25, on Win 10.
Verified as fixed on Firefox 120.0b4 (20231030023604 - treeherder build) and Firefox 121.0a1 (20231028092407) on Win 10, Ubuntu 22 and macOS 10.15.

Comment 12

[Donal Meehan [:dmeehan]]

Comment on attachment 9360485 [details]
Bug 1861253 - Draw select's menulist arrow in the select's color. r=dholbert,#layout

Approved for 119.0.1

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/2fa0c55df41d

Comment 14

[Giorgia Nichita, Release Desktop QA]

Verified as fixed on Firefox 119.0.1 (20231106151204) on Win 10, Ubuntu 22 and macOS 13.1