1861285 - DNS-over-HTTPS (DoH, TRR) provider default is not the one labelled "default"

Status: VERIFIED FIXED

(Core :: Networking: DNS, defect, P2)

Description

[Peter Simonyi]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/119.0

Steps to reproduce:

In Firefox preferences (Privacy & Security tab, "Enable secure DNS using" section), switch to "Default Protection" or "Off" (if it's not there already).
Then switch to "Increased Protection" or "Max Protection".

Actual results:

The provider chosen in the "Choose provider" box is "Cloudflare".

Expected results:

The provider chosen should be "CIRA Canadian Shield (Default)", or else I suppose the "(Default)" label should be applied to Cloudflare instead. Either way, the default should be the one labelled "Default".

Comment 1

[Peter Simonyi]

This is on an en-US build of Firefox running in Canada on Linux (official Mozilla build, not packaged).
The full list of providers is

• CIRA Canadian Shield (Default)
• Cloudflare
• NextDNS
• Custom

After switching to Increased or Max protection, the chosen provider in the dropdown box is always Cloudflare, even if you pick something else, switch DoH off, and then switch back to Increased or Max.

Also, the "Status" summary above the selection options does not match — it does show CIRA even though the dropdown shows Cloudflare. So maybe I'm mischaracterizing it as a problem of 'which is the real default' and the problem is that the select box is not hooked up correctly to the underlying state?

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Networking: DNS' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[edgul]

I'm not sure exactly what the desired behaviour should be, but if we look at the behaviour of switching between increased protection (NextDNS) and OFF and back to increased protection, this flow behaves as I would expect: status bar shows NextDNS, then OFF, then NextDNS while the dropdown menu selection shows NextDNS. Ie. It remembered what we previously had selected here.

If we do the same with switching to Default Protection instead of OFF we see the status bar switch to the "labelled default" Cira, but the checkbox selection shows cloudflare. I'm guessing, in this case, that the status bar is correct representation of state and there is a bug in the drop down selection, but we may also want to address the inconsistency between Default Protection and Off. In one case we remember, in the other we don't and fallback to default.

Comment 4

[Sean Kim [:sekim]]

Attachment: Bug 1861285 - DNS-over-HTTPS (DoH, TRR) provider change from default to increased/max protection set network.trr.uri to fallbackProviderURI while maintaining other mode changes r?edgul,valentin

Comment 5

[Sean Kim [:sekim]]

Attachment: Bug 1861285 - DNS-over-HTTPS (DoH, TRR) provider change to default stores the previous network.trr.uri value r?edgul,valentin

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3ef9d4d9be5
DNS-over-HTTPS (DoH, TRR) provider change from default to increased/max protection set network.trr.uri to fallbackProviderURI while maintaining other mode changes r=edgul,valentin,settings-reviewers,Gijs

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/d3ef9d4d9be5

Comment 8

[Ada C.]

Reproduced the issue on Firefox 127.
Verified as fixed using the latest Nightly 129.0a1 and Firefox 128.0b2 on Ubuntu 22.04, macOS 14 and Windows 11 x64.