1861296 - Remove or update probes expiring in Firefox 122: blocklist.* before Gecko version gets increased to 122 on 2023-11-20

Status: RESOLVED FIXED

(Toolkit :: Blocklist Implementation, task, P1)

Description

[telemetry-probes]

The following Firefox probes will expire in the next major Firefox nightly release: version 122 [1].

blocklist.addonBlockChange#addonBlockChange
blocklist.lastModified_rs_addons
blocklist.lastModified_rs_addons_mlbf
blocklist.mlbf_enabled
blocklist.mlbf_source
blocklist.mlbf_generation_time
blocklist.mlbf_stash_time_oldest
blocklist.mlbf_stash_time_newest

What to do about this:

1. If one, some, or all of the metrics are no longer needed, please remove them from their definitions files (Histograms.json, Scalars.yaml, Events.yaml).
2. If one, some, or all of the metrics are still required, please submit a Data Collection Review [2] and patch to extend their expiry. There is a shorter form for data collection renewal [3].

If you have any problems, please ask for help on the #data-help Slack channel or the #telemetry Matrix room at https://chat.mozilla.org/#/room/#telemetry:mozilla.org. We'll give you a hand.

Your Friendly, Neighborhood Telemetry Team

[1] https://wiki.mozilla.org/Release_Management/Calendar
[2] https://wiki.mozilla.org/Firefox/Data_Collection
[3] https://github.com/mozilla/data-review/blob/master/renewal_request.md

This is an automated message sent from probe-scraper. See https://github.com/mozilla/probe-scraper for details.

Comment 1

[:Gijs (he/him)]

Rob / Mathieu, do you think we still need these probes?

Comment 2

[Rob Wu [:robwu]]

Yes. I'll take care of renewal.

Comment 4

[Rob Wu [:robwu]]

Attachment: renewal_request-blocklist-v3-usage-telemetry.md

Data review request; Compared to previous blocklist probe requests, blocklist.mlbf_enabled has now been omitted because it was removed in bug 1820155 (which I requested during review).

Comment 5

[Travis Long [:travis_]]

Comment on attachment 9360649 [details]
renewal_request-blocklist-v3-usage-telemetry.md

Data Collection Renewal Review

1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

2. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Tracking because at least toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_mlbf_telemetry.js checks for this.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox121 (nightly). We have limited time to fix this, the soft freeze is in 14 days. However, the bug still has low priority.

:mixedpuppy, could you please increase the priority for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 8

[Rob Wu [:robwu]]

Attachment: Bug 1861296 - Update blocklist telemetry expiry to 132

And remove the mention of the blocklist.mlbf_enabled scalar, since its
implementation was removed in bug 1820155. Note that mlbf_enabled
defaulted to true since Firefox 78 (bug 1631018), and that the pref to
revert it was removed in Firefox 91 (bug 1706391). The latter was
desktop-only, but the telemetry wasn't sent on Android anyway. The
Glean-based telemetry was introduced in Firefox 115 (bug 1820155) along
with the removal of mlbf_enabled.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58e4bd7fa9a8
Update blocklist telemetry expiry to 132 r=rpl

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/58e4bd7fa9a8