Closed
Bug 1861455
Opened 2 years ago
Closed 2 years ago
Replace redundant Mode type with Browsing Mode
Categories
(Firefox for Android :: Homepage, enhancement, P3)
Tracking
()
RESOLVED
FIXED
121 Branch
People
(Reporter: matt-tighe, Assigned: matt-tighe)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxdroid])
Attachments
(1 file)
There are two types that track private browsing mode in the app:
BrowsingMode, which is used by theBrowsingModeManagerMode, which is kept in theAppStore
These types are redundant and don't seem to add any additional semantic value. There is risk of them getting out of sink, and cognitive overhead of the codebase is higher.
Since BrowsingMode is used more broadly, replace usages of Mode with it.
|
||
Updated•2 years ago
|
|
||
Comment 1•2 years ago
|
||
|
|
||
Comment 2•2 years ago
|
||
Authored by https://github.com/MatthewTighe
https://github.com/mozilla-mobile/firefox-android/commit/23d73586239edb8021af7ae9efb690b3080bbf34
[main] Bug 1861455 - Unify PBM types by replacing Mode with BrowsingMode
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox121:
--- → fixed
Flags: qe-verify+
Resolution: --- → FIXED
Target Milestone: --- → 121 Branch
|
Assignee | |
Updated•2 years ago
|
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•