1861457 - Support different list of retailers in FR/DE strings

Status: RESOLVED FIXED

(Firefox :: Messaging System, task, P1)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

We have a string[1] that lists three retailers in en-US, but the same string in FR/DE will need to only list one retailer. We'll need to figure out how we can show the correct string in FR/DE.

It might be enough to switch the string, based on which domain the user is visiting: if the location is amazon.fr or amazon.de, show a different string.

[1] https://searchfox.org/mozilla-central/source/browser/locales/en-US/browser/shopping.ftl#200-205

# Dynamic subtitle. Sites are limited to Amazon, Walmart or Best Buy.
# Variables:
# $currentSite (str) - The current shopping page name
# $secondSite (str) - A second shopping page name
# $thirdSite (str) - A third shopping page name
shopping-onboarding-dynamic-subtitle-1 = See how reliable product reviews are on <b>{ $currentSite }</b> before you buy. Review Checker, an experimental feature from { -brand-product-name }, is built right into the browser. It works on <b>{ $secondSite }</b> and <b>{ $thirdSite }</b>, too.

Comment 1

[wrocklin]

FYI string for FR/DE is here https://docs.google.com/spreadsheets/d/1FQUU2pqhKkAXRHNbmK9dhObwvevWoR3N6BOh3fu2skE/edit#gid=64342838 See row 64

Comment 2

[Ron Manning]

Testing the Jira link.

Comment 3

[Emily McMinn :emcminn]

Hi Jared! I have a tentative patch for this; is there an efficient way to test the DE/FR locales? Would adding the TLDs (as per this comment) be enough, locally?

EDIT: I'm also happy to take bug 1855760 if that would be helpful!

Comment 4

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Hey Emily,

Thanks for the ping. I think bug 1855760 should be more or less orthogonal to the changes needed here; how you are doing the domain detection in your patch? The shopping sidebar child actor already sends down the product URL when we trigger onboarding, to support the existing dynamic text[1], so I would guess the simplest way would be to add the new amazon.de and amazon.fr TLDs to the existing AWSetProductURL call[2], but that's without looking too much at the onboarding code (there might be a better way).

[1] https://searchfox.org/mozilla-central/source/browser/components/shopping/ShoppingSidebarChild.sys.mjs#360

[2] https://searchfox.org/mozilla-central/source/browser/components/newtab/aboutwelcome/AboutWelcomeChild.sys.mjs#828

Comment 5

[Emily McMinn :emcminn]

Attachment: Bug 1861457 - Handle FR and DE domains for onboarding subtitle

Comment 6

[Emily McMinn :emcminn]

I've added a new string, and shortcut the amazon.fr and amazon.de TLDs to it in AboutWelcomeChild. Adding fr and de to the validTLDs array did allow me to see the change working locally, but I've omitted that change from this patch, and can submit it as a patch to the other bug (along with some test cases) :)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2805138dc4b4
Handle FR and DE domains for onboarding subtitle r=jhirsch,fluent-reviewers,flod,shopping-reviewers

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/2805138dc4b4