Closed Bug 1861541 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 42796 - Improve scroller loop for intersection observer scroll margin

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
121 Branch
Tracking Flags:
Tracking Status
firefox121 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 42796 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/42796
Details from upstream follow.

Xianzhu Wang <wangxianzhu@chromium.org> wrote:

Improve scroller loop for intersection observer scroll margin

Now if there are scroll margins, collect the intermediate scrollers
into a vector in RootAndTarget when walking the containing block
chain in RootAndTarget::ComputeRelationship() instead of walk the
containing block chain again in ClipToRoot(). For scroll margin,
ClipToRoot() now calls ApplyClip() in a loop instead of calling
itself recursively.

Bug: 1485750
Change-Id: I0be9ff83df91969c9253235e11387dbe48042a82

Reviewed-on: https://chromium-review.googlesource.com/4977999
WPT-Export-Revision: 69d9a85b758c59788694feab96736f6e1d80f9dc

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 2
PASS: 1
FAIL: 1

Chrome

OK : 2
PASS: 1
FAIL: 1

Safari

OK : 2
PASS: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d52b3d7f51af [wpt PR 42796] - Improve scroller loop for intersection observer scroll margin, a=testonly https://hg.mozilla.org/integration/autoland/rev/e39166bb06ea [wpt PR 42796] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ce68f2b12ad2 [wpt PR 42796] - Improve scroller loop for intersection observer scroll margin, a=testonly https://hg.mozilla.org/integration/autoland/rev/2624af704a2e [wpt PR 42796] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/ce68f2b12ad2
https://hg.mozilla.org/mozilla-central/rev/2624af704a2e

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox121: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 121 Branch
You need to log in before you can comment on or make changes to this bug.