1861566 - Remove direct dependencies to non root-nodes in the compile graph in root-deps.mk

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1861566 - Remove direct dependencies to non root-nodes in the compile graph in root-deps.mk.

As the comment said, adding these dependencies was showing good results
back when it was done. 6~7 years later, things have changed, and
removing them makes the build faster across the board (tested from -j4
to -j48, they're up to 10% faster, with the biggest difference at -j16
and -j24)

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49997e56dea5
Remove direct dependencies to non root-nodes in the compile graph in root-deps.mk. r=firefox-build-system-reviewers,ahochheiden

Comment 3

[Noemi Erli[:noemi_erli]]

Backed out changeset 49997e56dea5 (Bug 1861566) for causing build bustage CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=etTn7a6pRKihAyuIIH-OeQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=49997e56dea501cbc8eff33303fcc2aa663df970

Log: https://treeherder.mozilla.org/logviewer?job_id=434120907&repo=autoland&lineNumber=81424

Backout: https://hg.mozilla.org/integration/autoland/rev/5c87acee8b894f06e4b248cb602b36ccfcef1615

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1861566 - Allow some missing generated source files.

When gtest is not linked as part of the build, the source files that are
generated for it are not necessarily created during the build, so we
won't be able to find them when packaging them. We make this an allowed
situation. Ideally, we'd "just" figure out which files these are, and
not emit them in the list of generated sources, but at the moment, it's
a lot of work to be able to do so.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2bee4ca6cc38
Allow some missing generated source files. r=firefox-build-system-reviewers,sergesanspaille
https://hg.mozilla.org/integration/autoland/rev/1deecddcfe56
Remove direct dependencies to non root-nodes in the compile graph in root-deps.mk. r=firefox-build-system-reviewers,ahochheiden

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2bee4ca6cc38
https://hg.mozilla.org/mozilla-central/rev/1deecddcfe56