1861605 - Use IDXGIResource1::CreateSharedHandle() instead of IDXGIResource::GetSharedHandle()

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

gecko uses IDXGIResource::GetSharedHandle(). It seems better to use IDXGIResource1::CreateSharedHandle() instead.

chromium always use the CreateSharedHandle().

• https://learn.microsoft.com/en-us/windows/win32/api/dxgi/nf-dxgi-idxgiresource-getsharedhandle
• https://learn.microsoft.com/en-us/windows/win32/api/dxgi1_2/nf-dxgi1_2-idxgiresource1-createsharedhandle

The CreateSharedHandle() uses NT handle (needs D3D11_RESOURCE_MISC_SHARED_NTHANDLE flag).

Comment 1

[Sotaro Ikeda [:sotaro]]

From https://learn.microsoft.com/en-us/windows/win32/api/d3d11/ne-d3d11-d3d11_resource_misc_flag

---

D3D11_RESOURCE_MISC_SHARED_NTHANDLE
Value: 0x800L
Set this flag to enable the use of NT HANDLE values when you create a shared resource. By enabling this flag, you deprecate the use of existing HANDLE values.

The value specifies a new shared resource type that directs the runtime to use NT HANDLE values for the shared resource. The runtime then must confirm that the shared resource works on all hardware at the specified feature level.

Without this flag set, the runtime does not strictly validate shared resource parameters (that is, formats, flags, usage, and so on). When the runtime does not validate shared resource parameters, behavior of much of the Direct3D API might be undefined and might vary from driver to driver.

Direct3D 11 and earlier: This value is not supported until Direct3D 11.1.

Comment 2

[Sotaro Ikeda [:sotaro]]

:jrmuizel, don't we need to use the CreateSharedHandle() instead of the GetSharedHandle()?

Comment 3

[Jeff Muizelaar [:jrmuizel]]

I think switching would be good to do.

Comment 4

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1861605 - Use IDXGIResource1::CreateSharedHandle() instead of IDXGIResource::GetSharedHandle()

Comment 5

[Sotaro Ikeda [:sotaro]]

NT HANDLE needs to be delivered by using ipc::FileDescriptor.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2721b6999583
Use IDXGIResource1::CreateSharedHandle() instead of IDXGIResource::GetSharedHandle() r=gfx-reviewers,lsalzman

Comment 7

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/2721b6999583