1861615 - Freeze at nsUserIdleService::GetIdleTime()

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Martin Stránský [:stransky] (ni? me)]

Freeze at nsUserIdleService::GetIdleTime():

#0  0x00007f4979f071ad in poll () at /lib64/libc.so.6
#1  0x00007f4978971629 in g_main_context_iterate.isra () at /lib64/libglib-2.0.so.0
#2  0x00007f4978912aff in g_main_loop_run () at /lib64/libglib-2.0.so.0
#3  0x00007f49787ed405 in g_dbus_connection_send_message_with_reply_sync () at /lib64/libgio-2.0.so.0
#4  0x00007f49787f2153 in g_dbus_connection_call_sync_internal () at /lib64/libgio-2.0.so.0
#5  0x00007f4978804d9f in g_dbus_proxy_call_sync_internal () at /lib64/libgio-2.0.so.0
#6  0x00007f4978804fbb in g_dbus_proxy_call_sync () at /lib64/libgio-2.0.so.0
#7  0x00007f4971c7d506 in UserIdleServiceMutter::PollIdleTime(unsigned int*) () at /usr/lib64/firefox/libxul.so
#8  0x00007f4973427391 in nsUserIdleService::GetIdleTime(unsigned int*) () at /usr/lib64/firefox/libxul.so
#9  0x00007f49734b3796 in nsUserIdleService::IdleTimerCallback() () at /usr/lib64/firefox/libxul.so
#10 0x00007f4972c5ca86 in nsTimerEvent::Run() () at /usr/lib64/firefox/libxul.so

we may try to implement it as async.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1861615 [Linux] Get idle time async from DBus r?emilio

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c49f13a2dc69
[Linux] Get idle time async from DBus r=emilio

Comment 3

[Noemi Erli[:noemi_erli]]

Backed out changeset c49f13a2dc69 (Bug 1861615) for causing failures in test_bug343416.xhtml and test_ext_idle.html CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=Z1HSbzF0R9iDukRBRRwqqg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Copt%2Cmochitests%2Cwithout%2Ce10s%2Cor%2Cfission%2Ctest-linux1804-64-qr%2Fopt-mochitest-chrome-1proc%2Cc3&revision=c49f13a2dc69c34c44c6ebda324446c0a1d7f707

Log: https://treeherder.mozilla.org/logviewer?job_id=434082207&repo=autoland&lineNumber=3779
https://treeherder.mozilla.org/logviewer?job_id=434087714&repo=autoland&lineNumber=9137

Backout: https://hg.mozilla.org/integration/autoland/rev/b2240cf1997407f513bd1ab3210a3067ac414860

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/ec7d4cb306bc
Backed out changeset c49f13a2dc69 for causing failures in test_bug343416.xhtml and test_ext_idle.html CLOSED TREE

Comment 5

[Iulian Moraru]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/b2240cf19974

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1861615 [Linux] Fallback to another idle service type from UserIdleServiceMutter::PollIdleTime() r?emilio

Allow to switch to another idle service type if UserIdleServiceMutter::PollIdleTime() fails. We recently see that failures on Mozilla try servers as:
Failed to call GetIdletime(): GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name org.gnome.Mutter.IdleMonitor was not provided by any .service files

Depends on D192061

Comment 7

[Martin Stránský [:stransky] (ni? me)]

try: https://treeherder.mozilla.org/jobs?repo=try&revision=14df416f14c086675ad0d24b0a3f7bd786d240e3

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d76528ae6c2
[Linux] Get idle time async from DBus r=emilio
https://hg.mozilla.org/integration/autoland/rev/73d527cf7fe4
[Linux] Fallback to another idle service type from UserIdleServiceMutter::PollIdleTime() r=emilio

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/6d76528ae6c2
https://hg.mozilla.org/mozilla-central/rev/73d527cf7fe4

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:stransky, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox120 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9360596 [details]
Bug 1861615 [Linux] Get idle time async from DBus r?emilio

Beta/Release Uplift Approval Request

• User impact if declined: We have reported repeated Firefox freezes on Gnome/Mutter caused by DBus interface. Fedora ships downstream patch for it.
  With async DBus handling we don't freeze if there's any issue which may block Firefox.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): Switches Idle service to asyc, may potentially introduce any bug here.
• String changes made/needed:
• Is Android affected?: No

Comment 12

[Dianna Smith [:diannaS] - on Leave, back on August 9th]

Comment on attachment 9360596 [details]
Bug 1861615 [Linux] Get idle time async from DBus r?emilio

Approved for 120.0b7

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/2af5b8132299
https://hg.mozilla.org/releases/mozilla-beta/rev/a8eb7938131d