1861616 - Background media playing stops after closing the custom tab or opening the custom tab in Fenix

Status: RESOLVED FIXED

(Firefox for Android :: General, defect)

Description

[killercontact1.7.4.0]

Steps to reproduce:

Has been reproducible for at least 1-2 years.

Galaxy A71 on Fenix Beta 120.0b2 2015981850, also on Nightly.

Fenix set as default browser so it is invoked for Custom Tabs in Android
In Fenix, load any stream that normally keeps on playing in the background, such as an internet radio
Use any app that uses Custom Tabs to load a page
Close the Custom Tab either with the X button or with a back gesture.

Actual results:

The background media stops when the custom tab closes.

Expected results:

Background media remains unaffected.

Comment 1

[Delia Pop (Android QA)]

Confirming this issue is reproducible on the latest Firefox for Android Versions. The media player (I used rockfm.ro) is paused when closing the custom tab.
The media player is also paused when opening the custom tab in Fenix (open the 3-dot menu from from the custom tab toolbar > tap on "Open in Firefox").
Reproducible on:

• Nightly 121.0a1
• Beta 120.0b2
• RC 119.0
  Tested with:
• Samsung Galaxy A53 5G (Android 13)
• Xiaomi Redmi Note 8T (Android 11)

Comment 2

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1861616 - Prevent Custom Tabs from stopping background media (#5143)

Comment 3

[BMO Github Automation]

Authored by https://github.com/t-p-white
https://github.com/mozilla-mobile/firefox-android/commit/e83e8e6e2007a220d1d996063a8b70bb7bd9f469
[main] Bug 1861616 - Prevent Custom Tabs from stopping background media

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:towhite, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox122 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1861616 - Prevent Custom Tabs from stopping background media (backport #5143) (#5183)

Comment 7

[twhite]

Comment on attachment 9373028 [details] [review]
[mozilla-mobile/firefox-android] Bug 1861616 - Prevent Custom Tabs from stopping background media (backport #5143) (#5183)

Beta/Release Uplift Approval Request

• User impact if declined: User may experience background media being stopped if a custom tab is closed
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The condition to stop the media is now gated based on the Activity which is always known
• String changes made/needed:
• Is Android affected?: No

Comment 8

[Donal Meehan [:dmeehan]]

Comment on attachment 9373028 [details] [review]
[mozilla-mobile/firefox-android] Bug 1861616 - Prevent Custom Tabs from stopping background media (backport #5143) (#5183)

Fx122 is now in RC, switching request from beta to release

Comment 9

[killercontact1.7.4.0]

Confirmed fixed on Samsung OneUI 5.1 Android 13. Thank you

Comment 10

[Donal Meehan [:dmeehan]]

Comment on attachment 9373028 [details] [review]
[mozilla-mobile/firefox-android] Bug 1861616 - Prevent Custom Tabs from stopping background media (backport #5143) (#5183)

Approved for Fenix 122.0 RC2

Comment 11

[BMO Github Automation]

Authored by https://github.com/t-p-white
https://github.com/mozilla-mobile/firefox-android/commit/63c42fa4ccef28bebb24a188ead017bd9f7abf45
[releases_v122] Bug 1861616 - Prevent Custom Tabs from stopping background media