1861622 - IrishCasing.cpp: do not use 'else' after 'return'

Status: RESOLVED FIXED

(Core :: Internationalization: Localization, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

do not use 'else' after 'return':
https://searchfox.org/mozilla-central/source/intl/unicharutil/util/IrishCasing.cpp#228-249

Hopefully, this will simplify this code

As the change is simple, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[Robert Longson [:longsonr]]

Isn't intl third party code (https://searchfox.org/mozilla-central/source/intl/update-icu.sh) and therefore any fix would need to be either made upstream or be performed by a local patch run by that script. The instructions in comment 0 don't seem to cover that.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Seems that it is our:
https://hg.mozilla.org/mozilla-central/rev/37d09834dd1eccaa2fefdf4674afbd21cf8f821f

especially with the license header on top (we usually don't put it when it isn't our code)

Comment 3

[Tawah Peggy]

Attachment: Bug 1861622 - Do not use 'else' after 'return'. r?Sylvestre

Comment 4

[Tawah Peggy]

Attachment: Bug 1861622 - Simplify the code by removing some 'else' r?Sylvestre

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b830cf04501
Simplify the code by removing some 'else' r=jfkthame DONTBUILD

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/2b830cf04501