1861645 - Replace KeywordUtils use of nsIScriptableUnicodeConverter with Services.textToSubURI.ConvertAndEscape

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P3)

Description

[Mark Banner (:standard8)]

KeywordUtils is currently using nsIScriptableUnicodeConverter in a convert and escape style routine:

https://searchfox.org/mozilla-central/rev/c51359e1e6beeb6cee5eafe67272c9be16fcf5c1/toolkit/modules/KeywordUtils.sys.mjs#66-79

We should be able to replace that section with Services.textToSubURI.ConvertAndEscape.

We may need to be careful to ensure the regexp replacement (/[+@\/]+/g) still works correctly as well.

It is possible we'll need to create some tests for this - or at least find if they exist in the urlbar tests (which is the only place that currently uses it).

Comment 1

[Knot False]

Attachment: Bug 1861645 - Replace KeywordUtils use of nsIScriptableUnicodeConverter. r=standard8!

Comment 2

[Mark Banner (:standard8)]

Would you be able to update the patch to rebase it, and remove the comment I left mention about in the review?

Comment 4

[Mark Banner (:standard8)]

I've updated the patch will probably land it tomorrow.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8ee966b78d68
https://hg.mozilla.org/integration/autoland/rev/2eb1ab6e8c67
Replace KeywordUtils use of nsIScriptableUnicodeConverter. r=hsivonen

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/2eb1ab6e8c67