1861652 - Address Duplication Detection rules not respected in Name, Organization, City and Street Address fields

Status: RESOLVED INVALID

(Toolkit :: Form Autofill, task)

Description

[Ina Popescu, Desktop QA]

Attachment: Street address duplication.mp4

Found in

• Nightly 121.0a1

Affected versions

• Nightly 121.0a1

Tested platforms

• Affected platforms: Windows 10 x64, macOS 11

Preconditions

• Set browser.search.region to CA or US in about:config
• Flip following prefs in about:config:
  extensions.formautofill.addresses.capture.v2.enabled = true
  extensions.formautofill.addresses.supported = on
• Use VPN to test

Steps to reproduce

1. Access https://luke-chang.github.io/autofill-demo/autocomplete-us-separate-fields.html?

2. Fill in the form as shown below, press the submit button
   Name: John Doe
   Street Address: 123 Main St. Apt 4A, Floor 2(test also for the address "123 E Evelyn Ave, Apt 4")
   City: Happy Valley Goose Bay(test also for the city "Düsseldorf")
   State: Labrador
   ZIP Code: A0P 1C0
   Organization: mozilla(test also for the organization "food and pharmacy")
   Country or Region: Canada
   Phone: [phone]
   Email: [e-mail]

3. Double click in any field and select the address from the autofill dropdown

4. Modify some values as shown below and submit the form(two times in a row for some of the fields)

• Name
  John Doe ⟷ Jöhn Döe

• Organization
  mozilla ⟷ mözilla
  food and pharmacy ⟷ pharmacy and food ⟷ pharmacy-and-food

• City
  Happy Valley Goose Bay ⟷ Happy Valley-Goose Bay
  Düsseldorf ⟷ Dusseldorf

• Street Address
  123 Main St. Apt 4A, Floor 2 = 123 Main St. Suite 4A, 2nd Fl
  123 main st. Apt 4a, Floor 2 = 123 Main St. Suite 4A, Fl. 2
  123 E Evelyn Ave, Apt 4 ⊃ 123 E Evelyn Ave

Expected result

• No Save/Update address capture doorhanger is displayed.

Actual result

• The Update address capture doorhanger is displayed.

Regression range

• N/A

Comment 1

[Dimi Lee [:dimi]]

Hi Ina, I chatted with :Alin offline about this is expected behavior due to ⟷ means the two values are "similar". When values are considered "similar", we will show the update doorhanger so users can decide whether to update them.
Could you help check whether our current behavior follows the rule? thank you!

Comment 2

[Ina Popescu, Desktop QA]

Attachment: 2023-11-03_13h53_43.mp4

Comment 3

[Ina Popescu, Desktop QA]

(In reply to Dimi Lee [:dimi] from comment #1)

Hi Ina, I chatted with :Alin offline about this is expected behavior due to ⟷ means the two values are "similar". When values are considered "similar", we will show the update doorhanger so users can decide whether to update them.
Could you help check whether our current behavior follows the rule? thank you!

Thanks Dimi for the explanation.
I've retested the Address Duplication Detection rules, but I'm not sure if the doorhanger is displayed properly in the following case:

123 E Evelyn Ave, Floor 2 vs 123 E Evelyn Ave, Floor 2, Apt 4 currently SAVE address doorhanger is displayed
Should the Update address doorhanger be displayed instead?
Please see also the attachment.

Comment 4

[Dimi Lee [:dimi]]

(In reply to Ina Popescu, Desktop QA from comment #3)

I've retested the Address Duplication Detection rules, but I'm not sure if the doorhanger is displayed properly in the following case:

123 E Evelyn Ave, Floor 2 vs 123 E Evelyn Ave, Floor 2, Apt 4 currently SAVE address doorhanger is displayed
Should the Update address doorhanger be displayed instead?
Please see also the attachment.

You are right, in the above case, the address update doorhanger should be displayed. Could you help file a bug for it? thanks!

Comment 5

[Ina Popescu, Desktop QA]

(In reply to Dimi Lee [:dimi] from comment #4)

(In reply to Ina Popescu, Desktop QA from comment #3)

I've retested the Address Duplication Detection rules, but I'm not sure if the doorhanger is displayed properly in the following case:

123 E Evelyn Ave, Floor 2 vs 123 E Evelyn Ave, Floor 2, Apt 4 currently SAVE address doorhanger is displayed
Should the Update address doorhanger be displayed instead?
Please see also the attachment.

You are right, in the above case, the address update doorhanger should be displayed. Could you help file a bug for it? thanks!

Thank you for confirming.
I've filed Bug 1863712.
Closing this one as RESOLVED INVALID.