1861655 - Wrong navigation id for browsingContext.navigate with wait=none

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P1)

Description

[Julian Descottes [:jdescottes]]

browsingContext.navigate expects to read the navigation id for the browsingContext just before resolving, but in case of a wait=none navigation, we might not have had time for the content process listener to reach the parent process.

In those cases the navigation id returned from browsingContext.navigate will be the previous one stored for this navigation.

We should create the id directly in browsingContext.navigate since we know we should expect a navigation, and also this is in-line with the BiDi spec for await a navigation which says that the navigation UUID should be created here and used by HTML's navigate.

We can basically do the same as what the network module does for beforeRequestSent: https://searchfox.org/mozilla-central/rev/c51359e1e6beeb6cee5eafe67272c9be16fcf5c1/remote/webdriver-bidi/modules/root/network.sys.mjs#472-480

Comment 1

[Julian Descottes [:jdescottes]]

Looking at Bug 1769514, we need to be careful not to simply trigger a navigation-started whenever browsingContext.navigate is called.
navigate could very well just result in a fragment navigation, and in that case even if we want a navigation id, we don't want navigation-started / stopped.

Which means we should only create/prepare the id, but not force the creation of events. Whereas it's safe to do from the network module, because a navigation request means we have a navigation-started event.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1861655 - [bidi] Create navigation id in browsingContext.navigate

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1861655 - [wdspec] Add BiDi navigationStarted test for locationchange happening before load

Depends on D192110

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I'll check if this is landable.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I've requested lando to land the revisions.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4180e81f2e99
[bidi] Create navigation id in browsingContext.navigate r=webdriver-reviewers,Sasha
https://hg.mozilla.org/integration/autoland/rev/e6241b851988
[wdspec] Add BiDi navigationStarted test for locationchange happening before load r=webdriver-reviewers,Sasha

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43007 for changes under testing/web-platform/tests

Comment 9

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/4180e81f2e99
https://hg.mozilla.org/mozilla-central/rev/e6241b851988

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot