1861690 - Browser sometimes closes when test is reloaded with `--pause-after-test`

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect)

Description

[James Graham [:jgraham]]

This appears to be a race condition with trying to run the "wait" webdriver script.

Comment 1

[James Graham [:jgraham]]

Attachment: Bug 1861690 - Fix race condition with reloads in --pause-after-test,

With --pause-after-test WebDriver runs a script and waits for an
exception that indicates the test window closed.

However this is problematic on reload because the navigation also
interrupts the script. We handle a JavascriptException by trying to
rerun the script, but if the reload is slow (e.g. in a debug build) we
can be trying to run the script in a window where the marionette
JSWindowActors are not yet loaded. In that case marionette arbitarily
returns null as the script result.

To handle this case, if we get a result for the script, check if it's
null and if it is just rerun rather than exiting.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49ec04348186
Fix race condition with reloads in --pause-after-test, r=Sasha

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/42838 for changes under testing/web-platform/tests

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/49ec04348186

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot