1861694 - Incorrect card displayed when the analysis was started from a different device

Status: VERIFIED FIXED

(Fenix :: Shopping, defect, P3)

Description

[miralobontiu]

Prerequisites

1. On Android, make sure to enable the shopping experience (tap 5 times on the logo, and enabled the option from Secret settings).
2. On Desktop, make sure to enable the shopping experience (in about:config, set the browser.shopping.experience2023.enabled pref to "true", and the browser.shopping.experience2023.optedIn pref to "1").

Steps to reproduce

1. On Desktop, go to an amazon.com, bestbuy.com, or walmart.com, find a product without reviews.
2. Click on the shopping icon to trigger the bottom sheet, but don't click on anything else.
3. Send the product detailed page from step 1 to an Android device.
4. Now, on both devices the "Check review quality" option is displayed.
5. On Desktop, tap on the "Check review quality" - the spinner is displayed, the user is informed that the analysisi has began.
6. On Android, tap the shopping icon, and observe.

Expected behavior

The bottom sheet on Android should display the loading indicators.

Actual behavior

The bottom sheet displays the same card: "Check review quality".

Device information

• Firefox version: Nightly 121.0a1 from 10/27
• Android devices: Xiaomi Mi8 Lite (Android 10), Oppo Find N2 Flip (Android 13)

Any additional information?

• If the review is checked first on Android, clicking on desktop the "Check review quality" blue button triggers a loading spinner that informs the user an analysis is already in progress.

Comment 1

[Chris Peterson [:cpeterson]]

This bug has been fixed on desktop.

Comment 2

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1861694 - Use analysis status to restore (re)analysis state (#4587)

Comment 3

[BMO Github Automation]

Authored by https://github.com/rahulsainani
https://github.com/mozilla-mobile/firefox-android/commit/860162c33c8519b80b65351d040989c88835cf6b
[main] Bug 1861694 - Use analysis status to restore (re)analysis state

Comment 4

[miralobontiu]

Verified as fixed on Fenix Nightly 122.0a1 from 12/5 with Oppo Find N2 Flip (Android 13), and Windows 10.

Comment 5

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1861694 - Use analysis status to restore (re)analysis state (backport #4587) (#4706)

Comment 6

[Rahul Sainani [:rsainani]]

Comment on attachment 9367034 [details] [review]
[mozilla-mobile/firefox-android] Bug 1861694 - Use analysis status to restore (re)analysis state (backport #4587) (#4706)

Beta/Release Uplift Approval Request

• User impact if declined: Reanalysis flow for review checker might not work as expected if another user/client starts the reanalysis.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Present in the bug.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's well tested by unit tests and verified in nightly.
• String changes made/needed: no
• Is Android affected?: Yes

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9367034 [details] [review]
[mozilla-mobile/firefox-android] Bug 1861694 - Use analysis status to restore (re)analysis state (backport #4587) (#4706)

Approved for 121.0b8.

Comment 8

[BMO Github Automation]

Authored by https://github.com/rahulsainani
https://github.com/mozilla-mobile/firefox-android/commit/7fa8996f0aca661e5938607d469f26dcb8ea45b1
[releases_v121] Bug 1861694 - Use analysis status to restore (re)analysis state

Comment 9

[miralobontiu]

Verified as fixed on Fenix Beta 121.0b8 with Google Pixel 6 (Android 14), and Windows 10.