1861732 - Shopping - Split-out "terms of use" and "privacy policy" text links

Status: VERIFIED FIXED

(Fenix :: Shopping, task, P1)

Description

[Noah Bond [:007]]

The "terms of use" and "privacy policy" links in the Shopping onboarding need to be split out in order to better support accessibility via Talkback and ensure those links open within Firefox.

Comment 1

[Chris Peterson [:cpeterson]]

Still waiting for a design decision

Comment 2

[Noah Bond [:007]]

Attachment: Figma

Comment 3

[Noah Bond [:007]]

Confirmed the links will be split onto their own line (see figma attachment). Waiting for updated copy to accommodate the localization issue.

Comment 4

[Noah Bond [:007]]

Updated copy:

By selecting "Yes, try it" you agree to the following from Fakespot:

Localization note from Katie L:
"In addition the string change, this note should also be added in the l10n comments. After the colon, what appears are two links, each on their own line. The first link is to a Privacy policy. The second link is to Terms of use."

Comment 5

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1861732 - Split-out "terms of use" and "privacy policy" text links (#4324)

Comment 6

[BMO Github Automation]

Authored by https://github.com/MozillaNoah
https://github.com/mozilla-mobile/firefox-android/commit/55d9274577a4d2589e1e90c8117fa3d1291c5ffe
[main] Bug 1861732 - Split-out "terms of use" and "privacy policy" text links

Comment 7

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1861732 - Split-out "terms of use" and "privacy policy" text links (backport #4324) (#4339)

Comment 8

[Noah Bond [:007]]

Comment on attachment 9361694 [details] [review]
[mozilla-mobile/firefox-android] Bug 1861732 - Split-out "terms of use" and "privacy policy" text links (backport #4324) (#4339)

Beta/Release Uplift Approval Request

• User impact if declined: The Fakespot onboarding links will not be accessible with a11y tools
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1859906
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch simply updates the copy of one string and moves two text links onto their own lines
• String changes made/needed:
• Is Android affected?: Yes

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9361694 [details] [review]
[mozilla-mobile/firefox-android] Bug 1861732 - Split-out "terms of use" and "privacy policy" text links (backport #4324) (#4339)

Approved for Mobile 120.0b6 (string changes approved by delphine)

Comment 10

[BMO Github Automation]

Authored by https://github.com/MozillaNoah
https://github.com/mozilla-mobile/firefox-android/commit/228a660405a3f3fff49fce4fec2e6a6fd5127af2
[releases_v120] Bug 1861732 - Split-out "terms of use" and "privacy policy" text links

Comment 11

[Adina Petridean QA [:apetridean]]

Verified as fixed on Nightly 121.0a1 from 11/03 with Motorola Moto G9 plus (Android 11) and Sony Xperia (Android 6.0.1).

Comment 12

[Adina Petridean QA [:apetridean]]

Attachment: links.JPEG

Comment 13

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1861732 - Remove straight quotes from shopping onboarding caption (#4360)

Comment 14

[BMO Github Automation]

Authored by https://github.com/MozillaNoah
https://github.com/mozilla-mobile/firefox-android/commit/d43fdfdbc6af69db4784b6ee2b2331f786e2d494
[main] Bug 1861732 - Remove straight quotes from onboarding caption

Comment 15

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1861732 - Clean up shopping onboarding caption strings (#4380)

Comment 16

[BMO Github Automation]

Authored by https://github.com/MozillaNoah
https://github.com/mozilla-mobile/firefox-android/commit/43a93b3da041ac4ff14bd1c9cd0fec3890975729
[main] Bug 1861732 - Clean up shopping onboarding caption strings

Comment 17

[Adina Petridean QA [:apetridean]]

Verified as fixed on Firefox Beta 120.0b7 with Motorola Moto G9 plus (Android 11) and Sony Xperia (Android 6.0.1).